cli/command: change uses of ListOpts.GetAll for GetSlice#6031
Merged
thaJeztah merged 1 commit intodocker:masterfrom Apr 23, 2025
Merged
cli/command: change uses of ListOpts.GetAll for GetSlice#6031thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
thaJeztah
added
status/2-code-review
kind/refactor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6031 +/- ##
=======================================
Coverage 58.91% 58.91%
=======================================
Files 358 358
Lines 29983 29983
=======================================
Hits 17664 17664
Misses 11339 11339
Partials 980 980 🚀 New features to boost your workflow:
|
2 tasks
The `GetSlice()` function is part of cobra's [cobra.SliceValue] interface, and duplicates the older `GetAll()` method. This patch changes our use of the `GetAll()` method with the intent to deprecated it in future. [cobra.SliceValue]: https://pkg.go.dev/github.com/spf13/cobra@v1.9.1#SliceValue Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
change_flag_uses
branch
from
e45cb58 to
22a5736
Compare
Member
Author
robmry
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
GetSlice()function is part of cobra's cobra.SliceValue interface,and duplicates the older
GetAll()method. This patch changes our useof the
GetAll()method with the intent to deprecated it in future.- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)