mount /var/run/docker.sock for --use-api-socket#6157
Merged
thaJeztah merged 1 commit intodocker:masterfrom Jul 1, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6157 +/- ##
=======================================
Coverage 54.82% 54.83%
=======================================
Files 364 364
Lines 30470 30467 -3
=======================================
Hits 16706 16706
+ Misses 12789 12786 -3
Partials 975 975 🚀 New features to boost your workflow:
|
2bde860 to
163f4c6
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
s.dockerCli.DockerEndpoint().Hostreturns the engine URL as seen by client, which is only relevant an Unix/MacOS with a local docker engine. Waiting for engine to expose this information in some API, or implement this feature on its own, hard-coding/var/run/docker.sockoffer a more reliable path for engine socket to be mounted in container, while not 100% guaranteed to succeed.- How I did it
hard-coded path
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)