image load: don't depend on deprecated JSONMessage.error field#3307
Merged
thompson-shaun merged 1 commit intodocker:mainfrom Jan 17, 2025
Merged
image load: don't depend on deprecated JSONMessage.error field#3307thompson-shaun merged 1 commit intodocker:mainfrom
thompson-shaun merged 1 commit intodocker:mainfrom
Conversation
The error field was deprecated in favor of the errorDetail struct in [moby@3043c26], but the API continued to return both. This patch updates docker-py to not depend on the deprecated field. [moby@3043c26]: moby/moby@3043c26 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
p1-0tr
approved these changes
Jan 14, 2025
p1-0tr
left a comment
p1-0tr
left a comment
There was a problem hiding this comment.
LGTM (not an expert on either the moby API or python, so "seems to do what it says on the tin" could be more accurate)
thompson-shaun
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error field was deprecated in favor of the errorDetail struct in moby@3043c26, but the API continued to return both. This patch updates docker-py to not depend on the deprecated field.