Fix null binary rowversion and add test coverage#1688
Merged
David-Engel merged 1 commit intodotnet:mainfrom Aug 4, 2022
Merged
Fix null binary rowversion and add test coverage#1688David-Engel merged 1 commit intodotnet:mainfrom
David-Engel merged 1 commit intodotnet:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1688 +/- ##
==========================================
- Coverage 71.40% 70.22% -1.19%
==========================================
Files 295 293 -2
Lines 61195 61384 +189
==========================================
- Hits 43697 43106 -591
- Misses 17498 18278 +780
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
|
It looks like the test CI is just broken. |
lcheunglci
approved these changes
Aug 2, 2022
David-Engel
approved these changes
Aug 3, 2022
Kaur-Parminder
approved these changes
Aug 3, 2022
|
It's very impressive to see this issue get fixed so quickly. I reported this bug 8 days ago and the fix is already merged into dotnet:main. This truly shows the power of open source and the direct interaction it brings between Microsoft and it's community of developers. Big shout out to @Wraith2 for fixing this so quickly. Impressed. |
David-Engel
added a commit
to David-Engel/SqlClient
that referenced
this pull request
Aug 9, 2022
Porting dotnet#1688 to 3.1-servicing.
David-Engel
added a commit
that referenced
this pull request
Aug 9, 2022
Porting #1688 to 3.1-servicing.
DavoudEshtehari
pushed a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Aug 11, 2022
DavoudEshtehari
pushed a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Aug 15, 2022
DavoudEshtehari
added a commit
that referenced
this pull request
Aug 23, 2022
DavoudEshtehari
added a commit
that referenced
this pull request
Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1684
The fix is very simple and simply adds a a null check that was already present in all the other SqlType returning properties on SqlBuffer. Test coverage is added for SqlBinary and SqlBytes in the existing test.
/cc @rclabo, @dbrownems