Check for ANDROID_HOME Sdk location on Windows.#230
Merged
jonpryor merged 2 commits intodotnet:mainfrom Apr 17, 2024
Merged
Conversation
For some reason we never check for the ANDROID_HOME environment variable on Windows. This might cause issues with people using VSCode since we probably will be using environment variables as a backup when using that IDE. So lets check those last in the list of paths. This way we will pick up all the other defaults and backups before trying the environment variable.
Contributor
Author
|
I added this becuse when writing the docs, I found that from the command line on windows you either have to
|
jonathanpeppers
approved these changes
Apr 12, 2024
jonpryor
pushed a commit
that referenced
this pull request
Apr 22, 2024
For some reason we never check for the `%ANDROID_HOME%` environment variable on Windows. This might cause issues with people using VSCode since we probably will be using environment variables as a backup when using that IDE. Add a check to use `%ANDROID_HOME%` after checking the registry entries. This way Visual Studio and Android SDK Installer paths will still be preferred.
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Apr 22, 2024
Changes: dotnet/android-tools@d3e7284...d50747c * dotnet/android-tools@d50747c: Check for ANDROID_HOME Sdk location on Windows. (dotnet/android-tools#230)
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Apr 23, 2024
Changes: dotnet/android-tools@d3e7284...d50747c * dotnet/android-tools@d50747c: Check for ANDROID_HOME Sdk location on Windows. (dotnet/android-tools#230)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason we never check for the ANDROID_HOME environment variable on Windows. This might cause
issues with people using VSCode since we probably
will be using environment variables as a backup when using that IDE.
So lets check those last in the list of paths. This way we will pick up all the other defaults and backups before trying the environment variable.