[Xamarin.Android.Build.Tasks] Enabling <AndroidUseSharedRuntime> in some projects causes classes.dex to not deploy to device.#236
Merged
jonpryor merged 1 commit intodotnet:masterfrom Sep 28, 2016
Conversation
|
Hi, when this will be included in a service release? |
…ome projects causes `classes.dex` to not deploy to device. Context https://bugzilla.xamarin.com/show_bug.cgi?id=44633 For some bizzare reason when running a build vs XS the AfterTargets are NOT being called for _CompileDex. As a result the targets that need to be called to support debugging are not being run. This commit adds a bunch of new property extension points which will allow the debugging targets to inject the additonal target requirements directly rather than relying on Before/After targets.
dellis1972
force-pushed
the
Bug44633
branch
from
26ac166 to
7757dc4
Compare
dellis1972
added a commit
that referenced
this pull request
Oct 4, 2016
Context https://bugzilla.xamarin.com/show_bug.cgi?id=44633 Enabling <AndroidUseSharedRuntime> in some projects causes `classes.dex` to not deploy to device. For some bizzare reason when running a build vs XS the AfterTargets are NOT being called for _CompileDex. As a result the targets that need to be called to support debugging are not being run. This commit adds a bunch of new property extension points which will allow the debugging targets to inject the additonal target requirements directly rather than relying on Before/After targets.
dellis1972
added a commit
that referenced
this pull request
Oct 4, 2016
Context https://bugzilla.xamarin.com/show_bug.cgi?id=44633 Enabling <AndroidUseSharedRuntime> in some projects causes `classes.dex` to not deploy to device. For some bizzare reason when running a build vs XS the AfterTargets are NOT being called for _CompileDex. As a result the targets that need to be called to support debugging are not being run. This commit adds a bunch of new property extension points which will allow the debugging targets to inject the additonal target requirements directly rather than relying on Before/After targets.
Contributor
|
@williamsrz This is slated for our SR1 release. |
radical
pushed a commit
that referenced
this pull request
May 8, 2018
Looks like Gendarme bug, the `TArray` is used for the cast, so it is not unused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context https://bugzilla.xamarin.com/show_bug.cgi?id=44633
For some bizzare reason when running a build vs XS the
AfterTargets are NOT being called for _CompileDex. As a
result the targets that need to be called to support
debugging are not being run.
This commit adds a new property called
which will allow the debugging targets to inject the
additonal target requirements directly rather than relying
on Before/After targets.