Hush some messages logged by default on startup#8414
Merged
jonpryor merged 2 commits intodotnet:mainfrom Oct 11, 2023
Merged
Conversation
We log a number of messages during startup, whether or not logging is enabled. However, logcat messages take non-trivial (and not entirely predictable) amount of time to process, so we should limit their number by default in order to speed up startup. Tests show the following improvements resulting from this change: * Displayed: 1.49% faster * Native-to-managed transition: 7.47% faster * Total native init time: 5.94% faster
Contributor
Author
|
I re-ran the performance tests with all of logcat logging disabled, including |
Contributor
We log a number of messages during startup, whether or not logging is
enabled. However, logcat messages take non-trivial (and not entirely
predictable) amount of time to process, so we should limit their
number by default in order to speed up startup.
Tests show the following improvements[^0] resulting from this change:
* Displayed: 6.28% faster
* Native-to-managed transition: 6.11% faster
* Total native init time: 13.95% faster
[^0]: Numbers from running [XAPerfTestRunner][0] with **all** of
logcat logging disabled, including `monodroid-timing` messages.
The `timing=fast-bare` mode is used, which doesn't log anything
until asked to do so.
This way logcat's inherently unpredictable behavior was
completely removed and the results are more stable.
[0]: https://github.com/grendello/XAPerfTestRunner |
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Oct 12, 2023
* main: [Xamarin.Android.Build.Tasks] Fix up ForegroundService.ToString() (dotnet#8412) [monodroid] Hush some messages logged by default on startup (dotnet#8414)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We log a number of messages during startup, whether or not logging is
enabled. However, logcat messages take non-trivial (and not entirely
predictable) amount of time to process, so we should limit their number
by default in order to speed up startup.
Tests show the following improvements resulting from this change: