Conversation
jonathanpeppers
approved these changes
Dec 6, 2023
Member
jonathanpeppers
left a comment
There was a problem hiding this comment.
So, I think this thing was created before .binlog files existed, as a custom MSBuild logger for timings. If we ever needed this information again, we'd probably just use MSBuild.StructuredLogger to open .binlog files instead.
grendello
approved these changes
Dec 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android-tools#220
Context: #8545
We added the ability for consumers of MSBuild NuGet packages to not add the
Microsoft.Buildpackage to their project. One project that currently still requiresMicrosoft.BuildisXamarin.Android.BootstrapTasks.However the only thing that uses
Microsoft.BuildisTimingLoggerwhich produced a build performance report for our old Jenkins build system. As we no longer use Jenkins or this code, removing it allows us to remove theMicrosoft.Builddependency.Removes warnings:
This reduces the number of CI reported warnings from 166 to 56.