Track Java.Interop.Tools.JavaCallableWrappers changes#8701
Merged
Conversation
jpobst
force-pushed
the
refactor-jcw
branch
3 times, most recently
from
f7ecb71 to
fd7e510
Compare
jpobst
force-pushed
the
refactor-jcw
branch
3 times, most recently
from
a2de5ab to
7e6ec67
Compare
Hopefully fixes the IL2035 warnings in CI.
There's no need to constantly create these values.
jpobst
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
jonathanpeppers
approved these changes
Feb 21, 2024
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
Otherwise, the code changes look OK to me.
|
|
||
| using (var writer = MemoryStreamPool.Shared.CreateStreamWriter ()) { | ||
| try { | ||
| var jti = new JavaCallableWrapperGenerator (t, Log.LogWarning, cache, classifier) { |
Member
There was a problem hiding this comment.
Since we don't pass in Log.LogWarning(), I wondered if we lost the ability to log warnings. But then I looked at the java.interop diff to see all the warnings commented out.
Is this something being worked on for a future PR? Just curious.
Contributor
Author
There was a problem hiding this comment.
Not that I know of. I assume these warnings were disabled for a reason?
But it would be pretty easy to add a logger property to CallableWrapperReaderOptions and/or CallableWrapperWriterOptions in the future if someone wanted to add more logging.
jpobst
changed the title
Java.Interop.Tools.JavaCallableWrappers changes
grendello
added a commit
that referenced
this pull request
Feb 22, 2024
* main: [xamarin-android-tools] import $(LibZipSharpVersion) value (#8738) Bump to xamarin/Java.Interop/main@c825dcad (#8701) Bump to xamarin/monodroid@cb01503327 (#8742) Bump to xamarin/Java.Interop/main@ae65609 (#8744)
grendello
added a commit
that referenced
this pull request
Feb 22, 2024
* main: [xamarin-android-tools] import $(LibZipSharpVersion) value (#8738) Bump to xamarin/Java.Interop/main@c825dcad (#8701) Bump to xamarin/monodroid@cb01503327 (#8742)
grendello
added a commit
that referenced
this pull request
Feb 28, 2024
* main: Bump to xamarin/xamarin-android-tools/main@37d79c9 (#8752) Bump to dotnet/installer@d070660282 9.0.100-preview.3.24126.2 (#8763) Bump to xamarin/java.interop/main@14a9470 (#8766) $(AndroidPackVersionSuffix)=preview.3; net9 is 34.99.0.preview.3 (#8765) [Mono.Android] Do not dispose request content stream in AndroidMessageHandler (#8764) Bump com.android.tools:r8 from 8.2.42 to 8.2.47 (#8761) [Mono.Android] fix a set of the "easiest" trimmer warnings (#8731) Bump to dotnet/installer@0a73f814e1 9.0.100-preview.2.24122.3 (#8716) [ci] Always run the MAUI test job (#8750) Add a property required by #8478 (#8749) [xamarin-android-tools] import $(LibZipSharpVersion) value (#8738) Bump to xamarin/Java.Interop/main@c825dcad (#8701) Bump to xamarin/monodroid@cb01503327 (#8742) Bump to xamarin/Java.Interop/main@ae65609 (#8744) Bring in changes from PR #8478 (#8727) [xaprepare] Make 7zip work with "dangerous" symlinks in ZIPs (#8737) Bump NDK to r26c (#8732) Debugging MSBuild Tasks (#8730)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: dotnet/java-interop#1174
In dotnet/java-interop#1174, we refactored
Java.Interop.Tools.JavaCallableWrappersto be more maintainable. This resulted in a changed public API for consuming the library.Update
Xamarin.Android.Build.Tasks.GenerateJavaStubsto consume the updated API.