Bump 'NuGet.*' and 'Newtonsoft.Json' NuGet versions.#8825
Conversation
jpobst
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
| <PackageReference Include="NuGet.Common" Version="6.7.0" /> | ||
| <PackageReference Include="NuGet.Packaging" Version="6.7.0" /> | ||
| <PackageReference Include="NuGet.ProjectModel" Version="6.7.0" /> | ||
| <PackageReference Include="NuGet.Common" Version="6.9.1" /> | ||
| <PackageReference Include="NuGet.Packaging" Version="6.9.1" /> | ||
| <PackageReference Include="NuGet.ProjectModel" Version="6.9.1" /> |
There was a problem hiding this comment.
Does anything actually use these? I have a vague memory of:
There was a problem hiding this comment.
Yes, we started using them for Java binding dependency verification: https://github.com/xamarin/xamarin-android/pull/8649/files#diff-747215dcfa29e845d4d353aacccca25500165f49c03992ed7b789a7bdfc54031.
We use it to read the NuGet project.assets.json file.
There was a problem hiding this comment.
Does something need to ship NuGet.Packaging.dll? I was looking for it in:
There was a problem hiding this comment.
I think it gets ILRepack'd into Xamarin.Android.Build.Tasks.dll.
There was a problem hiding this comment.
No, I didn't find it there either:
Ideally, we could stop IL repacking at some point. It causes problems when debugging this assembly, etc.
Is there at least one MSBuild test for this feature? Just wondering how it can load these assemblies -- maybe it "finds" them in the .NET SDK?
There was a problem hiding this comment.
There are tests for this feature: https://github.com/xamarin/xamarin-android/blob/main/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BindingBuildTest.cs#L775-L892
You may be right that it is finding the assemblies from another process.
src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj
Outdated
Show resolved
Hide resolved
* main: Bump to dotnet/installer@dc43d363d2 9.0.100-preview.4.24175.5 (#8828) [Xamarin.Android.Build.Tasks] Update to newer ILRepack which supports debug files. (#8839) Bump 'NuGet.*' and 'Newtonsoft.Json' NuGet versions. (#8825)
* main: Bump to dotnet/installer@dc43d363d2 9.0.100-preview.4.24175.5 (#8828) [Xamarin.Android.Build.Tasks] Update to newer ILRepack which supports debug files. (#8839) Bump 'NuGet.*' and 'Newtonsoft.Json' NuGet versions. (#8825) Localized file check-in by OneLocBuild Task (#8844) [LayoutBindings] Fix '[Preserve]' is obsolete warnings (#8529) LEGO: Merge pull request 8837
* main: Bump to dotnet/installer@dc43d363d2 9.0.100-preview.4.24175.5 (#8828) [Xamarin.Android.Build.Tasks] Update to newer ILRepack which supports debug files. (#8839) Bump 'NuGet.*' and 'Newtonsoft.Json' NuGet versions. (#8825) Localized file check-in by OneLocBuild Task (#8844) [LayoutBindings] Fix '[Preserve]' is obsolete warnings (#8529) LEGO: Merge pull request 8837 [ci] Use managed identity for ApiScan (#8823) [Xamarin.Android.Build.Tasks] DTBs should not rm generator output (#8706) [Xamarin.Android.Build.Tasks] Bump to NuGet 6.7.1 (#8833) $(AndroidPackVersionSuffix)=preview.4; net9 is 34.99.0.preview.4 (#8831) Localized file check-in by OneLocBuild Task (#8824) [Xamarin.Android.Build.Tasks] Enable POM verification features. (#8649) [runtime] Optionally disable inlining (#8798) Fix assembly count when satellite assemblies are present (#8790) [One .NET] new "greenfield" projects are trimmed by default (#8805) Localized file check-in by OneLocBuild Task (#8819) LEGO: Merge pull request 8820
2 participants
Update
NuGet.ProjectModelto the latest version. This new version requires a newer version ofNewtonsoft.Json, so update to the latest of it as well.Remove unneeded NuGet PackageReferences.