Set default for UseSizeOptimizedLinq#9718
Merged
jonathanpeppers merged 1 commit intodotnet:mainfrom Jan 29, 2025
Merged
Conversation
Sets the default for switch added in dotnet/sdk#46375. (Should merge before we start consuming the SDK/runtime that has this.)
MichalStrehovsky
requested review from
dellis1972 and
jonathanpeppers
as code owners
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jonathanpeppers
approved these changes
Jan 29, 2025
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
Looks like we have a few tests that fail if from a fork:
Test 'foo' requires a commercial build of .NET for Android.
I'll look into making these ignore instead of fail.
Member
|
Just a note that this change makes debug builds slightly bigger as we don't run the trimmer in them. |
Contributor
I did that on purpose. Because there were silently being skipped, and I was doing fast dev changes from a fork and none of the test were running. W |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets the default for switch added in dotnet/sdk#46375.
(Should merge before we start consuming the SDK/runtime that has this.)