Skip to content

[main] Update dependencies from dotnet/efcore dotnet/runtime#35547

Merged
dotnet-maestro[bot] merged 38 commits intomainfrom
darc-main-fcbf8a54-42e6-4ded-9535-034b26dfd6ba
Aug 29, 2021
Merged

[main] Update dependencies from dotnet/efcore dotnet/runtime#35547
dotnet-maestro[bot] merged 38 commits intomainfrom
darc-main-fcbf8a54-42e6-4ded-9535-034b26dfd6ba

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 20, 2021 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/efcore

  • Subscription: 8ce5251e-8269-419d-3b2a-08d8b8050dda
  • Build: 20210827.1
  • Date Produced: 8/27/2021 8:33 AM
  • Commit: 99a25a6ead6e0bec6358b82e200203eb497ab97f
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime

  • Subscription: 32db3699-5666-45da-a1b7-08d8b804cd75
  • Build: 20210828.3
  • Date Produced: 8/28/2021 12:19 PM
  • Commit: cffaa78235ea93d5e3eeb56956579df503e11250
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20210…
a100832 
…820.5

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design
 From Version 7.0.0-alpha.1.21419.9 -> To Version 7.0.0-alpha.1.21420.5
@dotnet-maestro dotnet-maestro bot requested a review from dougbu as a code owner August 20, 2021 11:14
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels Aug 20, 2021
ghost
ghost approved these changes Aug 20, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@ghost ghost added the tell-mode Indicates a PR which is being merged during tell-mode label Aug 20, 2021
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
903d164 
…0820.5

Microsoft.NETCore.Platforms , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.Win32.SystemEvents , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.Extensions.Primitives , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.Extensions.Options , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Configuration , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Hosting , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Ref , System.Windows.Extensions , System.Threading.Channels , System.Text.Json , System.Text.Encodings.Web , System.ServiceProcess.ServiceController , System.Drawing.Common , System.DirectoryServices.Protocols , System.Diagnostics.EventLog , System.Diagnostics.DiagnosticSource , System.IO.Pipelines , System.Security.Permissions , System.Security.Cryptography.Xml , System.Security.Cryptography.Pkcs , System.Runtime.CompilerServices.Unsafe , System.Resources.Extensions , System.Reflection.Metadata , System.Net.Http.WinHttpHandler , System.Net.Http.Json
 From Version 7.0.0-alpha.1.21419.1 -> To Version 7.0.0-alpha.1.21420.5
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/efcore [main] Update dependencies from dotnet/efcore dotnet/runtime Aug 20, 2021
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20210…
d046abf 
…820.12

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design
 From Version 7.0.0-alpha.1.21419.9 -> To Version 7.0.0-alpha.1.21420.12
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/efcore dotnet/runtime [main] Update dependencies from dotnet/runtime dotnet/efcore Aug 20, 2021
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20210…
8566b38 
…820.15

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design
 From Version 7.0.0-alpha.1.21419.9 -> To Version 7.0.0-alpha.1.21420.15
@BrennanConroy BrennanConroy mentioned this pull request Aug 20, 2021
Merged
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20210…
2008974 
…820.31

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design
 From Version 7.0.0-alpha.1.21419.9 -> To Version 7.0.0-alpha.1.21420.31
@BrennanConroy
Copy link
Member

BrennanConroy commented Aug 20, 2021

Waiting for dotnet/runtime#57858

@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20210…
903be6a 
…821.5

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design
 From Version 7.0.0-alpha.1.21419.9 -> To Version 7.0.0-alpha.1.21421.5
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
97d9233 
…0820.30

Microsoft.NETCore.Platforms , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.Win32.SystemEvents , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.Extensions.Primitives , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.Extensions.Options , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Configuration , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Hosting , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Ref , System.Windows.Extensions , System.Threading.Channels , System.Text.Json , System.Text.Encodings.Web , System.ServiceProcess.ServiceController , System.Drawing.Common , System.DirectoryServices.Protocols , System.Diagnostics.EventLog , System.Diagnostics.DiagnosticSource , System.IO.Pipelines , System.Security.Permissions , System.Security.Cryptography.Xml , System.Security.Cryptography.Pkcs , System.Runtime.CompilerServices.Unsafe , System.Resources.Extensions , System.Reflection.Metadata , System.Net.Http.WinHttpHandler , System.Net.Http.Json
 From Version 7.0.0-alpha.1.21419.1 -> To Version 7.0.0-alpha.1.21420.30
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/runtime dotnet/efcore [main] Update dependencies from dotnet/efcore dotnet/runtime Aug 21, 2021
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
10d5834 
…0821.5

Microsoft.NETCore.Platforms , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.Win32.SystemEvents , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.Extensions.Primitives , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.Extensions.Options , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Configuration , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Hosting , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Ref , System.Windows.Extensions , System.Threading.Channels , System.Text.Json , System.Text.Encodings.Web , System.ServiceProcess.ServiceController , System.Drawing.Common , System.DirectoryServices.Protocols , System.Diagnostics.EventLog , System.Diagnostics.DiagnosticSource , System.IO.Pipelines , System.Security.Permissions , System.Security.Cryptography.Xml , System.Security.Cryptography.Pkcs , System.Runtime.CompilerServices.Unsafe , System.Resources.Extensions , System.Reflection.Metadata , System.Net.Http.WinHttpHandler , System.Net.Http.Json
 From Version 7.0.0-alpha.1.21419.1 -> To Version 7.0.0-alpha.1.21421.5
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20210…
439b977 
…822.3

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design
 From Version 7.0.0-alpha.1.21419.9 -> To Version 7.0.0-alpha.1.21422.3
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/efcore dotnet/runtime [main] Update dependencies from dotnet/runtime dotnet/efcore Aug 22, 2021
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20210…
866e4df 
…823.3

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design
 From Version 7.0.0-alpha.1.21419.9 -> To Version 7.0.0-alpha.1.21423.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
b469ef0 
…0822.3

Microsoft.NETCore.Platforms , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.Win32.SystemEvents , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.Extensions.Primitives , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.Extensions.Options , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Configuration , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Hosting , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Ref , System.Windows.Extensions , System.Threading.Channels , System.Text.Json , System.Text.Encodings.Web , System.ServiceProcess.ServiceController , System.Drawing.Common , System.DirectoryServices.Protocols , System.Diagnostics.EventLog , System.Diagnostics.DiagnosticSource , System.IO.Pipelines , System.Security.Permissions , System.Security.Cryptography.Xml , System.Security.Cryptography.Pkcs , System.Runtime.CompilerServices.Unsafe , System.Resources.Extensions , System.Reflection.Metadata , System.Net.Http.WinHttpHandler , System.Net.Http.Json
 From Version 7.0.0-alpha.1.21419.1 -> To Version 7.0.0-alpha.1.21422.3
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/runtime dotnet/efcore [main] Update dependencies from dotnet/efcore dotnet/runtime Aug 23, 2021
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20210…
93d559d 
…823.4

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design
 From Version 7.0.0-alpha.1.21419.9 -> To Version 7.0.0-alpha.1.21423.4
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/efcore dotnet/runtime [main] Update dependencies from dotnet/runtime dotnet/efcore Aug 23, 2021
@JamesNK JamesNK mentioned this pull request Aug 23, 2021
Merged
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20210…
4fd1e36 
…824.3

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design
 From Version 7.0.0-alpha.1.21419.9 -> To Version 7.0.0-alpha.1.21424.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
6e4a318 
…0823.17

Microsoft.NETCore.Platforms , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.Win32.SystemEvents , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.Extensions.Primitives , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.Extensions.Options , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Configuration , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Hosting , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Ref , System.Windows.Extensions , System.Threading.Channels , System.Text.Json , System.Text.Encodings.Web , System.ServiceProcess.ServiceController , System.Drawing.Common , System.DirectoryServices.Protocols , System.Diagnostics.EventLog , System.Diagnostics.DiagnosticSource , System.IO.Pipelines , System.Security.Permissions , System.Security.Cryptography.Xml , System.Security.Cryptography.Pkcs , System.Runtime.CompilerServices.Unsafe , System.Resources.Extensions , System.Reflection.Metadata , System.Net.Http.WinHttpHandler , System.Net.Http.Json
 From Version 7.0.0-alpha.1.21419.1 -> To Version 7.0.0-alpha.1.21423.17
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/runtime dotnet/efcore [main] Update dependencies from dotnet/efcore dotnet/runtime Aug 24, 2021
@BrennanConroy
Copy link
Member

BrennanConroy commented Aug 24, 2021 •
edited
Loading

Runtime update we were waiting for is in, someone now needs to look into the failures (related to the Runtime change because StringSegment is now nullable annotated).

dougbu and others added 6 commits August 27, 2021 23:18
@dougbu
!fixup! Use ToString() instead of suppression
dbea160
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
9550049 
…0827.37

Microsoft.NETCore.Platforms , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.Win32.SystemEvents , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.Extensions.Primitives , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.Extensions.Options , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Configuration , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Hosting , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Ref , System.Windows.Extensions , System.Threading.Channels , System.Text.Json , System.Text.Encodings.Web , System.ServiceProcess.ServiceController , System.Drawing.Common , System.DirectoryServices.Protocols , System.Diagnostics.EventLog , System.Diagnostics.DiagnosticSource , System.IO.Pipelines , System.Security.Permissions , System.Security.Cryptography.Xml , System.Security.Cryptography.Pkcs , System.Runtime.CompilerServices.Unsafe , System.Resources.Extensions , System.Reflection.Metadata , System.Net.Http.WinHttpHandler , System.Net.Http.Json
 From Version 7.0.0-alpha.1.21419.1 -> To Version 7.0.0-alpha.1.21427.37
@dougbu
Update KnownHeaders
9ac655f 
- then regenerate HttpHeaders.Generated.cs
@dougbu
Do generated JS files need to change?
543efec
@dougbu
!fixup! Allow Charset to be null
992d844
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
1404d93 
…0828.3

Microsoft.NETCore.Platforms , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.Win32.SystemEvents , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.Extensions.Primitives , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.Extensions.Options , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Configuration , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Hosting , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Ref , System.Windows.Extensions , System.Threading.Channels , System.Text.Json , System.Text.Encodings.Web , System.ServiceProcess.ServiceController , System.Drawing.Common , System.DirectoryServices.Protocols , System.Diagnostics.EventLog , System.Diagnostics.DiagnosticSource , System.IO.Pipelines , System.Security.Permissions , System.Security.Cryptography.Xml , System.Security.Cryptography.Pkcs , System.Runtime.CompilerServices.Unsafe , System.Resources.Extensions , System.Reflection.Metadata , System.Net.Http.WinHttpHandler , System.Net.Http.Json
 From Version 7.0.0-alpha.1.21419.1 -> To Version 7.0.0-alpha.1.21428.3
davidfowl
davidfowl reviewed Aug 29, 2021
View reviewed changes
src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.Generated.cs
goto HeaderGrpcStatus;

default:
Copy link
Member

@davidfowl davidfowl Aug 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many trailing spaces

Copy link
Contributor

@dougbu dougbu Aug 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cleaned them up when I edited the file manually but the tests didn't like that. If you care, file an issue to clean up the trailing whitespace KnownHeaders generates.

@dougbu
Copy link
Contributor

dougbu commented Aug 29, 2021

/fyi we're down to 12 failing tests. I have a good idea what most of the issues are…

dougbu
dougbu reviewed Aug 29, 2021
View reviewed changes
src/Middleware/StaticFiles/src/StaticFileContext.cs Outdated

public StaticFileContext(HttpContext context, StaticFileOptions options, ILogger logger, IFileProvider fileProvider, string? contentType, PathString subPath)
{
if (!subPath.HasValue)
Copy link
Contributor

@dougbu dougbu Aug 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tratcher StaticFileMiddleware.ValidatePath(...) returns true when it sets subPath to PathString.Empty. In turn, PathString.Empty shows HasValue == false because that property uses !string.IsNullOrEmpty(Value). This feels like a bug -- an empty value is still a value and should get passed this check. Thoughts❔

For now, I'm going to change PathString.HasValue but I suspect my next iteration won't fix all the test failures. You have a bit of time ☹️

Copy link
Contributor

@dougbu dougbu Aug 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed my mind because the result is extra allocations e.g. UsePathBaseExtensions.UsePathBase(...) will add an unnecessary UsePathBaseMiddleware. Will instead change this to check subPath.Value == null.

dougbu added 2 commits August 29, 2021 13:35
@dougbu
!fixup! Adjust to fix failing tests
0d79864 
- note `HttpResponse.ContentType` type now matches `HttpRequest.ContentType`
@dougbu
!fixup! React to HttpResponse.ContentType change
f484c66
@dotnet-maestro dotnet-maestro bot merged commit 8bb1281 into main Aug 29, 2021
@dotnet-maestro dotnet-maestro bot deleted the darc-main-fcbf8a54-42e6-4ded-9535-034b26dfd6ba branch August 29, 2021 23:52
@ghost ghost added this to the 7.0-preview1 milestone Aug 29, 2021
@davidfowl
Copy link
Member

davidfowl commented Aug 30, 2021

@dougbu shouldn't this have been reviewed by multiple team members? Are you trying to unblock the dependency flow?

@dougbu
Copy link
Contributor

dougbu commented Aug 30, 2021

@dougbu shouldn't this have been reviewed by multiple team members? Are you trying to unblock the dependency flow?

Yes and yes. I've asked @Pilchie's team to file follow-up issues if necessary.

@davidfowl
Copy link
Member

davidfowl commented Aug 30, 2021

I'm super worried about this PR. Can you make sure that you remind everyone tomorrow

Tratcher
Tratcher reviewed Sep 2, 2021
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougbu we need to talk about the assumption that a StringValues array never contains nulls.

src/Http/Http/src/Internal/ResponseCookies.cs
for (var i = 0; i < values.Length; i++)
{
if (!rejectPredicate(values[i], encodedKeyPlusEquals, options))
var value = values[i]!;
Copy link
Member

@Tratcher Tratcher Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

src/Http/Shared/CookieHeaderParserShared.cs
Comment on lines -34 to -39
if (parsedName != null && parsedValue != null)
{
var name = enableCookieNameEncoding ? Uri.UnescapeDataString(parsedName.Value.Value) : parsedName.Value.Value;
store[name] = Uri.UnescapeDataString(parsedValue.Value.Value);
hasFoundValue = true;
}
Copy link
Member

@Tratcher Tratcher Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert. TryParseValue's [NotNullWhen(true)] markers are wrong, remove them. The parsedName and parsedValue can be null when supportsMultipleValues = true.

src/Middleware/ResponseCaching/src/ResponseCachingKeyProvider.cs
for (var i = 0; i < headersCount; i++)
{
var header = varyByRules!.Headers[i];
var header = varyByRules!.Headers[i]!;
Copy link
Member

@Tratcher Tratcher Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

src/Servers/Kestrel/Core/src/Internal/KestrelServerImpl.cs
}

private static void TriggerRebind(object state)
private static void TriggerRebind(object? state)
Copy link
Member

@Tratcher Tratcher Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We always register this callback with a state, so a Debug.Assert should be sufficient.

src/Shared/ChunkingCookieManager/ChunkingCookieManager.cs
for (var i = 0; i < values.Length; i++)
{
if (!rejectPredicate(values[i]))
var value = values[i]!;
Copy link
Member

@Tratcher Tratcher Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

src/Shared/HttpSys/RequestProcessing/HeaderCollection.cs
foreach (var value in headerValues)
{
ValidateHeaderCharacters(value);
ValidateHeaderCharacters(value!);
Copy link
Member

@Tratcher Tratcher Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

src/Shared/HttpSys/RequestProcessing/HeaderParser.cs
bool inQuotes = false;
int current = 0;
for ( ; current < value.Length; current++)
for ( ; current < value!.Length; current++)
Copy link
Member

@Tratcher Tratcher Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

src/Shared/RangeHelper/RangeHelper.cs

// Perf: Check for a single entry before parsing it
if (rawRangeHeader.Count > 1 || rawRangeHeader[0].IndexOf(',') >= 0)
if (rawRangeHeader.Count > 1 || rawRangeHeader[0]!.IndexOf(',') >= 0)
Copy link
Member

@Tratcher Tratcher Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@dougbu
Copy link
Contributor

dougbu commented Sep 2, 2021

@dougbu we need to talk about the assumption that a StringValues array never contains nulls.

Sure, I'm around and this type of feedback is why I included a number of reviewers and had offline (Teams) conversations w/ you, @BrennanConroy and @pranavkm. After some discussion, the consensus was StringValues in general could contain null entries but

  1. That would be very rare outside the one-item-exists-and-is-null case and that should be covered by IsNullOrEmpty(...). Count doesn't cover that case however.
  2. Headers and similar shouldn't fall into that pit of failure.

Separately, I shouldn't have changed behaviour because I tried very hard to only make changes in places where nullability was enabled. If a string method can return null in that context, it's a straight-up bug.

@dougbu dougbu requested a review from JamesNK September 3, 2021 23:51
@Tratcher
Copy link
Member

Tratcher commented Sep 7, 2021

It's OK to acknowledge that StringValues will rarely contain null array entries and not take the situation too seriously. I'm more concerned about the implementation having misleading ! overrides in it. The ! conveys that we've verified this value can't be null but the tooling isn't smart enough to follow our logic. This can be problematic for people maintaining the code starting from false assumptions.

I'd rather convey our decision that "it could be null but that's uncommon enough that we don't want to add special logic for it" more literally in the code, such as changing:

var value = values[i]!;

To:

var value = values[i] ?? string.Empty;

This isn't a lot of extra effort and more closely conveys the semantics of the situation. It has the added benefit of failing more gracefully if there ever are nulls in the array.

@dougbu
Copy link
Contributor

dougbu commented Sep 7, 2021

@Tratcher I'm fine w/ ?? string.Empty where I used ! in most of this PR. Wondering however whether Debug.Assert(...) might be a better statement of our intent wrt. headers, cookies, and so on❔

@dougbu
Copy link
Contributor

dougbu commented Sep 7, 2021

… "statement of our intent" and expectations … 😃

@Tratcher
Copy link
Member

Tratcher commented Sep 7, 2021

Debug.Assert still means we never expect null in that code path. If we're generating the StringValues then that's OK, but anywhere where we're taking StringValues from user input we can't make that assumption.

@dougbu
Copy link
Contributor

dougbu commented Sep 7, 2021

anywhere where we're taking StringValues from user input we can't make that assumption

That makes sense. Where exactly do we accept StringValues from anywhere except dotnet/runtime and dotnet/aspnetcore parsing of headers, cookies, and so on❔

@Tratcher
Copy link
Member

Tratcher commented Sep 8, 2021

Here's a good example:
#35547 (comment)

Kestrel's ValidateHeaderValueCharacters is run on user input response headers.

aspnetcore/src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.Generated.cs

Line 8330 in 1e57c10

ValidateHeaderValueCharacters(HeaderNames.Connection, value, EncodingSelector);

@dougbu dougbu mentioned this pull request Sep 27, 2021
Closed
@TanayParikh TanayParikh mentioned this pull request Mar 29, 2022
Closed
1 task
@campersau campersau mentioned this pull request Jun 16, 2022
Closed
1 task
@kchinburarat kchinburarat mentioned this pull request Dec 20, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidfowl davidfowl davidfowl left review comments

@Tratcher Tratcher Tratcher left review comments

@BrennanConroy BrennanConroy BrennanConroy left review comments

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@javiercn javiercn Awaiting requested review from javiercn

@Pilchie Pilchie Awaiting requested review from Pilchie

@pranavkm pranavkm Awaiting requested review from pranavkm

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

+3 more reviewers

@dougbu dougbu dougbu left review comments

@maxkoshevoi maxkoshevoi maxkoshevoi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dougbu dougbu

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode Type: Dependency Update 🔼

Projects

None yet

Milestone

7.0-preview1

Development

Successfully merging this pull request may close these issues.

7 participants

@BrennanConroy @dougbu @JamesNK @maxkoshevoi @davidfowl @Tratcher @eerhardt