Conversation
| implementation project(':core') | ||
| implementation 'org.msgpack:msgpack-core:0.8.20' | ||
| implementation 'org.msgpack:jackson-dataformat-msgpack:0.8.20' | ||
| implementation 'org.msgpack:msgpack-core:0.9.11' |
There was a problem hiding this comment.
Not needed, but saw a warning I thought would be fixed by an update. Updating is a good idea regardless though.
There was a problem hiding this comment.
Pull request overview
This PR updates the Gradle build system for the SignalR Java client, including a major version upgrade of the Gradle wrapper and modernization of build script syntax.
Key changes:
- Upgrades Gradle wrapper from version 8.10 to 9.2.1
- Updates msgpack dependencies from 0.8.20 to 0.9.11
- Modernizes Gradle syntax using explicit assignment operators (
=) for group, artifactId, version, and url properties - Adds junit-platform-launcher dependency for test runtime
- Updates gradlew and gradlew.bat scripts to match new Gradle version
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle-wrapper.properties | Updates Gradle distribution URL to 9.2.1, adds validation settings |
| gradle-wrapper.jar | Binary update for new Gradle wrapper version |
| gradlew | Updated Unix shell script with POSIX compliance improvements |
| gradlew.bat | Updated Windows batch script with improved error handling |
| build.gradle | Modernizes syntax with explicit assignment operators |
| core/build.gradle | Modernizes group and artifactId assignment syntax |
| messagepack/build.gradle | Updates msgpack dependencies and modernizes syntax |
| test/build.gradle | Adds junit-platform-launcher dependency |
| dependencies { | ||
| implementation 'org.junit.jupiter:junit-jupiter-params:5.11.2' | ||
| testImplementation 'org.junit.jupiter:junit-jupiter:5.11.2' | ||
| testRuntimeOnly 'org.junit.platform:junit-platform-launcher' |
There was a problem hiding this comment.
The junit-platform-launcher dependency is missing an explicit version number. While Gradle may resolve this transitively through other JUnit dependencies, it's a best practice to specify explicit versions for all dependencies to ensure reproducible builds and avoid potential version conflicts. Consider adding an explicit version, e.g., 'org.junit.platform:junit-platform-launcher:1.11.2' to match the other JUnit dependencies.
| testRuntimeOnly 'org.junit.platform:junit-platform-launcher' | |
| testRuntimeOnly 'org.junit.platform:junit-platform-launcher:1.11.2' |
There was a problem hiding this comment.
@BrennanConroy this will be important after #64962 goes in since ingesting new package versions into the AzDO feed requires auth
| distributionPath=wrapper/dists | ||
| distributionSha256Sum=5b9c5eb3f9fc2c94abaea57d90bd78747ca117ddbbf96c859d3741181a12bf2a | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.10-bin.zip | ||
| distributionSha256Sum=72f44c9f8ebcb1af43838f45ee5c4aa9c5444898b3468ab3f4af7b6076c5bc3f |
There was a problem hiding this comment.
The SHA256 checksum has been updated for the Gradle distribution. Please verify that this checksum (72f44c9f8ebcb1af43838f45ee5c4aa9c5444898b3468ab3f4af7b6076c5bc3f) corresponds to the actual Gradle 9.2.1 distribution file. If Gradle 9.2.1 does not exist, this checksum is invalid and could pose a security risk by potentially downloading an unintended or malicious file.
|
Does this impact this support statement? https://learn.microsoft.com/en-us/aspnet/core/signalr/supported-platforms?view=aspnetcore-10.0#java-client |
|
I'm a novice when it comes to java but given that we set sourceCompatibility to 1.9 here, I wonder if that support statement is already wrong for .NET 10 and should say Java 9? |
|
yeah it was bumped to 1.9 in https://github.com/dotnet/aspnetcore/pull/59788/changes#r1909555192 |
|
The part that made me question was that gradle statement about the 9.x runtime only being compatible with Java 25. I guess that might not matter if it's only a build dependency and not a runtime dependency. |
|
/backport to release/10.0 |
|
Started backporting to |
|
/backport to release/9.0 |
|
/backport to release/8.0 |
|
Started backporting to |
|
Started backporting to |
5 participants
No description provided.