Skip to content

Disable parallel restore for BuildAfterTargetingPack projects#65107

Merged
wtgodbe merged 2 commits intomainfrom
revert-65040-wtgodbe/GrpcWorkaround
Jan 17, 2026
Merged

Disable parallel restore for BuildAfterTargetingPack projects#65107
wtgodbe merged 2 commits intomainfrom
revert-65040-wtgodbe/GrpcWorkaround

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jan 16, 2026

Improvement on #65040, inspired by #65069

Copilot AI review requested due to automatic review settings January 16, 2026 23:53
@github-actions github-actions bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 16, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the RestoreDisableParallel workaround from BuildAfterTargetingPack projects. The workaround was previously needed to avoid restore conflicts (issue #61178), but is no longer necessary because BuildAfterTargetingPack.csproj now uses unique MSBuildRestoreSessionId values for each restore operation, which prevents conflicts without disabling parallel restore entirely.

Changes:

  • Removed RestoreDisableParallel property and associated workaround comments from two project files

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Grpc/JsonTranscoding/Directory.Build.props Removed RestoreDisableParallel workaround from Directory.Build.props affecting all Grpc JsonTranscoding projects
src/Framework/Microsoft.Internal.Aspnetcore.DotNetApiDocs.Transport/src/Microsoft.Internal.Aspnetcore.DotNetApiDocs.Transport.csproj Removed RestoreDisableParallel workaround from DotNetApiDocs.Transport project file

@wtgodbe wtgodbe merged commit 03d43ac into main Jan 17, 2026
25 checks passed
@wtgodbe wtgodbe deleted the revert-65040-wtgodbe/GrpcWorkaround branch January 17, 2026 01:54
@dotnet-policy-service dotnet-policy-service bot added this to the 11.0-preview1 milestone Jan 17, 2026
@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 21, 2026

/backport to release/10.0

@github-actions
Copy link
Contributor

Started backporting to release/10.0 (link to workflow run)

wtgodbe added a commit that referenced this pull request Jan 22, 2026
* Revert "Disable parallel restore for Grpc JsonTranscoding (#65040)"

This reverts commit d3f0774.

* Disable parallel build for delayed build projects
wtgodbe added a commit that referenced this pull request Jan 22, 2026
* Revert "Disable parallel restore for Grpc JsonTranscoding (#65040)"

This reverts commit d3f0774.

* Disable parallel build for delayed build projects
wtgodbe added a commit that referenced this pull request Feb 2, 2026
* Disable parallel restore for Grpc JsonTranscoding

* Update Microsoft.Internal.Aspnetcore.DotNetApiDocs.Transport.csproj

* Disable parallel restore for BuildAfterTargetingPack projects (#65107)

* Revert "Disable parallel restore for Grpc JsonTranscoding (#65040)"

This reverts commit d3f0774.

* Disable parallel build for delayed build projects

---------

Co-authored-by: William Godbe <wigodbe@microsoft.com>
wtgodbe added a commit that referenced this pull request Feb 2, 2026
* Disable parallel restore for Grpc JsonTranscoding

* Update Microsoft.Internal.Aspnetcore.DotNetApiDocs.Transport.csproj

* Disable parallel restore for BuildAfterTargetingPack projects (#65107)

* Revert "Disable parallel restore for Grpc JsonTranscoding (#65040)"

This reverts commit d3f0774.

* Disable parallel build for delayed build projects

---------

Co-authored-by: William Godbe <wigodbe@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments