This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Use Version suffix and clean versions#8724
Merged
ViktorHofer merged 6 commits intodotnet:masterfrom Nov 1, 2019
Merged
Conversation
6f9e71b to
5d5e022
Compare
dagood
approved these changes
Nov 1, 2019
Member
dagood
left a comment
There was a problem hiding this comment.
Plan seems fine. netstandard.library change seems weird though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires dotnet/arcade#4266
I'm consolidating all the version properties to use the
Versionsuffix instead ofPackageVersion. This aligns to Arcade conventions and extension point which also use theVersionsuffix.MicrosoftDotNetMaestroTasksVersionwhich is set in Arcade as well.