This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[RyuJIT/ARM32] Enable casting from small int to float#11643
Merged
BruceForstall merged 1 commit intodotnet:masterfrom May 19, 2017
Merged
[RyuJIT/ARM32] Enable casting from small int to float#11643BruceForstall merged 1 commit intodotnet:masterfrom
BruceForstall merged 1 commit intodotnet:masterfrom
Conversation
This just enable casting from small int to float by removing assertion. Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Member
Author
|
I think we should generate |
Member
Author
|
I found out that instruction is correctly generated. From the encoding in JitDump @dotnet/jit-contrib Please take a look. BTW JitDump and JitDisasm shows wrong register number for double register for ARM32. |
BruceForstall
approved these changes
May 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just enable casting from small int to float by removing assertion and generated code is verified with tests.
Fix #11603
Example
JIT/Methodical/fp/exgen/10w250d_cs_d/10w250d_cs_d.exeBefore
After (Ryujit)
Legacy JIT
Same sequence of
vmov.i2fandvcvt.i2dare generated for ryujit and legacy jit for casting from small int type to double.