This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Emit Fixup for local method import#7724
Merged
cshung merged 1 commit intodotnet:masterfrom Aug 27, 2019
Merged
Conversation
jkotas
reviewed
Aug 22, 2019
src/ILCompiler.ReadyToRun/src/Compiler/DependencyAnalysis/ReadyToRunCodegenNodeFactory.cs
Outdated
Show resolved
Hide resolved
cshung
force-pushed
the
dev/andrewau/local-method-import-fixup
branch
from
7426477 to
67e7a97
Compare
jkotas
reviewed
Aug 26, 2019
src/ILCompiler.ReadyToRun/src/Compiler/DependencyAnalysis/ReadyToRunCodegenNodeFactory.cs
Outdated
Show resolved
Hide resolved
trylek
approved these changes
Aug 26, 2019
Member
trylek
left a comment
trylek
left a comment
There was a problem hiding this comment.
LGTM overall modulo JanK's comment regarding GC ref map. Thanks for fixing this!
src/ILCompiler.ReadyToRun/src/Compiler/DependencyAnalysis/ReadyToRunCodegenNodeFactory.cs
Outdated
Show resolved
Hide resolved
src/ILCompiler.ReadyToRun/src/Compiler/DependencyAnalysis/ReadyToRun/PrecodeMethodImport.cs
Outdated
Show resolved
Hide resolved
src/ILCompiler.ReadyToRun/src/Compiler/DependencyAnalysis/ReadyToRunCodegenNodeFactory.cs
Show resolved
Hide resolved
cshung
force-pushed
the
dev/andrewau/local-method-import-fixup
branch
from
67e7a97 to
b9efcd4
Compare
cshung
force-pushed
the
dev/andrewau/local-method-import-fixup
branch
from
b9efcd4 to
647b52d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixed this test case in CoreCLR.
JIT\Methodical\delegate\_simpleoddpower_il_d\CPAOT-ret.out\_simpleoddpower_il_d.cmd