Highlight stackalloc keyword#132
Merged
DustinCampbell merged 2 commits intodotnet:masterfrom Aug 28, 2018
worldbeater:patch-1
Merged
Highlight stackalloc keyword#132DustinCampbell merged 2 commits intodotnet:masterfrom worldbeater:patch-1
stackalloc keyword#132DustinCampbell merged 2 commits intodotnet:masterfrom
worldbeater:patch-1
Conversation
DustinCampbell
approved these changes
Aug 28, 2018
Member
DustinCampbell
left a comment
DustinCampbell
left a comment
There was a problem hiding this comment.
Any chance you could add a test?
Contributor
Author
|
Sure. Will need some time. |
Member
|
Cool. It should be easy to add. Just follow the pattern in https://github.com/dotnet/csharp-tmLanguage/blob/master/test/expressions.tests.ts. |
Contributor
Author
|
@DustinCampbell here you are. 👍 |
aeschli
pushed a commit
to microsoft/vscode
that referenced
this pull request
Sep 17, 2018
* Adds support for the `stackalloc` keyword. [csharp-tmLanguage#132](dotnet/csharp-tmLanguage#132) _(Contributed by [@worldbeater](https://github.com/worldbeater))_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. You know, there is a keyword in C# language named
stackalloc. This keyword doesn't get highlighted properly in Visual Studio Code editor and on Github. Both services highly depend oncsharp-tmLanguage, so let's improve them. This PR brings support forstackallockeyword highlighting! Thanks @nestquik for reviewing this.