Add OSR to DacpTieredVersionData#2928
Merged
hoyosjs merged 2 commits intodotnet:mainfrom Mar 11, 2022
Merged
Conversation
Member
Author
|
@noahfalk / @mikem8361 PTAL. If you mirror updates to dacprivate.h from the runtime repo, let me know and I'll remove that bit. |
72 tasks
mikem8361
suggested changes
Mar 11, 2022
src/SOS/Strike/util.cpp
Outdated
| case DacpTieredVersionData::OptimizationTier_OptimizedTier1: | ||
| descriptor = "OptimizedTier1"; | ||
| break; | ||
| case DacpTieredVersionData::OptimizationTier_OptimizedTier1: |
Contributor
There was a problem hiding this comment.
I think you meant to use OptimizationTier_OptimizedTier1OSR here.
mikem8361
approved these changes
Mar 11, 2022
hoyosjs
approved these changes
Mar 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to dotnet/runtime#66507