Skip to content

Comments

Remove enum members and printout of transient flags#5715

Merged
rcj1 merged 4 commits intodotnet:mainfrom
rcj1:remove-transient-flags
Feb 13, 2026
Merged

Remove enum members and printout of transient flags#5715
rcj1 merged 4 commits intodotnet:mainfrom
rcj1:remove-transient-flags

Conversation

@rcj1
Copy link
Contributor

@rcj1 rcj1 commented Feb 13, 2026

@rcj1 rcj1 requested review from jkotas, noahfalk and tommcdon February 13, 2026 06:54
@rcj1 rcj1 requested a review from a team as a code owner February 13, 2026 06:54
Copilot AI review requested due to automatic review settings February 13, 2026 06:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes unused enum members from the transient flags enumeration in the SOS debugger extension and simplifies the DumpModule command output by removing the raw hex printout of transient flags. The change is based on feedback from a related PR discussion.

Changes:

  • Removed all unused enum members from the transient flags enumeration, keeping only IS_EDIT_AND_CONTINUE
  • Updated comments to reflect that only a single value remains in the enum
  • Removed the "TransientFlags: %08x" printout line from DumpModule command output

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@rcj1 rcj1 merged commit 553a5f3 into dotnet:main Feb 13, 2026
19 checks passed
@rcj1 rcj1 deleted the remove-transient-flags branch February 13, 2026 13:20
leculver pushed a commit to leculver/diagnostics that referenced this pull request Feb 19, 2026
Context:
dotnet/runtime#124309 (comment)

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants