Documentation fix for Socket.Select#9992
Merged
gewarren merged 2 commits intodotnet:mainfrom Jul 19, 2024
Merged
Conversation
dotnet-policy-service
bot
added
the
community-contribution
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
This comment was marked as outdated.
This comment was marked as outdated.
`System.TimesSpan` states that `ArgumentNullException` is thrown if any of checkRead, checkWrite or checkError is empty/null. But, null or empty collections can be passed for them. The real requirement is that at least one of them must contain at least one socket. It is perfectly okay to `select(read_sockets, NULL, NULL)` or `select(NULL, write_sockets, NULL)` or `select(NULL, NULL, error_sockets)`.
logiclrd
force-pushed
the
JDG_SocketSelectDocumentationFix
branch
from
3614685 to
dca5418
Compare
|
Learn Build status updates of commit dca5418: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit 0ab0a2b: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Socket.Selectdocumentation (for the overload wheretimeoutis aSystem.TimeSpan) states thatArgumentNullExceptionis thrown if any ofcheckRead,checkWriteorcheckErroris empty/null. But, null or empty collections can be passed for them. The real requirement is that at least one of them must contain at least one socket. It is perfectly okay toselect(read_sockets, NULL, NULL)orselect(NULL, write_sockets, NULL)orselect(NULL, NULL, error_sockets).