Better completion

[vasily-kirichenko]

This partially fixes #3937

[saul]

Looks great. Any chance we could add a test for this?

[vasily-kirichenko]

@dotnet-bot test Windows_NT Release_ci_part1 Build please

[vasily-kirichenko]

It's ready.

[cartermp]

Interestingly, I get a value suggested as the type when I first type the parameter type name, but if I go back, it's not there (testing on a .NET Core console app):

[vasily-kirichenko]

There is no ast until you close the paren. This is the same problem as with attributes completion - it suggests full type name until you close >]

[cartermp]

Yeah, just debugged this and noticed it 😄 . I suppose we can file that as a future problem to tackle. This looks good!

[vasily-kirichenko]

I’m not sure we can solve this problem without improving the parser. And i’m not sure it could be improved :)

[cartermp]

Should this be named ParameterTypeAnnotation or TypeAnnotation?

[cartermp]

Looks like TypeAnnotation would be the better candidate of my two suggestions since it is also hit here:

let foo (s: string): ^

[vasily-kirichenko]

No, this is for xx: type at any place, not just for parameters. And this thing is called pattern I think.

[cartermp]

Hmm, I think what you're referring to is the patterns that have type annotations, so PatternWithTypeAnnotation would be the name I'd think of here. That may have been what you meant, but when I read PatternType I thought it was referring to a completion context which constituted a pattern of any kind.

[smoothdeveloper]

I believe Pattern refers to the bound pattern (when deconstructing a DU, a tuple, a record, etc.) and Type to the type annotation.

let foo ((Some s): string option) = ...

parameter can be a simple symbol but also can be a pattern.

[vasily-kirichenko]

Ooookey, it's ready.

[KevinRansom]

Thank you for this.