Merged
Conversation
Context: dotnet#1153 *Actually* building *and running* NativeAOT artifacts requires .NET 8. Update `$(DotNetTargetFramework)` so that .NET 8 is used.
Contributor
Author
|
jpobst
approved these changes
Feb 8, 2024
Contributor
jpobst
left a comment
jpobst
left a comment
There was a problem hiding this comment.
However, this only affects main and it is unlikely that we would switch AndroidX/GPS to using .NET 9 preview packages. The branch we ship .NET 8 packages out of will remain built with net7.0 so this shouldn't affect AndroidX/GPS.
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Feb 9, 2024
Changes: dotnet/java-interop@7f08b77...dfcbd67 * dotnet/java-interop@dfcbd670: Bump to xamarin/xamarin-android-tools/main@a698a33 (dotnet/java-interop#1189) * dotnet/java-interop@6182baff: [build] Target `net8.0` (dotnet/java-interop#1186) dotnet/java-interop@6182baff updated Java.Interop to target .NET 8 instead of .NET 7. This introduced a build break: …/xamarin-android/src/Mono.Android/Mono.Android.csproj(402,5): error MSB3030: Could not copy the file "…/xamarin-android/external/Java.Interop/bin/Debug-net7.0/ref/Java.Interop.dll" because it was not found. Introduce a new `$(JavaInteropTargetFrameworkVersion)` MSBuild property within `Configuration.props` which contains the .NET version that Java.Interop is targeting. Update `Mono.Android.csproj` and `Microsoft.Android.Ref.proj` so that they use `$(JavaInteropTargetFrameworkVersion)` to locate the reference `Java.Interop.dll` assembly.
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Feb 9, 2024
Changes: dotnet/java-interop@7f08b77...dfcbd67 * dotnet/java-interop@dfcbd670: Bump to xamarin/xamarin-android-tools/main@a698a33 (dotnet/java-interop#1189) * dotnet/java-interop@6182baff: [build] Target `net8.0` (dotnet/java-interop#1186) dotnet/java-interop@6182baff updated Java.Interop to target .NET 8 instead of .NET 7. This introduced a build break: …/xamarin-android/src/Mono.Android/Mono.Android.csproj(402,5): error MSB3030: Could not copy the file "…/xamarin-android/external/Java.Interop/bin/Debug-net7.0/ref/Java.Interop.dll" because it was not found. Introduce a new `$(JavaInteropTargetFrameworkVersion)` MSBuild property within `Configuration.props` which contains the .NET version that Java.Interop is targeting. Update `Mono.Android.csproj` and `Microsoft.Android.Ref.proj` so that they use `$(JavaInteropTargetFrameworkVersion)` to locate the reference `Java.Interop.dll` assembly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #1153
Actually building and running NativeAOT artifacts requires .NET 8.
Update
$(DotNetTargetFramework)so that .NET 8 is used.