Merged
Conversation
This also removes workarounds that are no longer necessary, using built-in extension points to the nuget Pack target instead of a custom .nuspec. The new package includes a netcoreapp2.0 and a net472 build of ILLink.Tasks, as well as the illink.dll command-line tool invoked by the task (on netcoreapp2.0).
Via rollForwardOnNoCandidateFx.
Also rename the property to ILLinkTasksAssembly
tkapin
pushed a commit
to tkapin/runtime
that referenced
this pull request
Jan 31, 2023
For dotnet/sdk#3125. This most notably adds a net472 build of ILLink.Tasks, and modifies Sdk.props to import the correct build of the tasks, depending on the MSBuild runtime type. This makes it possible to use the linker tasks on desktop MSBuild once again. Regardless of the MSBuild runtime, illink.dll will run on .NET Core. We set 'rollForwardOnNoCandidateFx' to allow running on .NET Core 3 (even though illink.dl is built targeting netcoreapp2.0). This change removes many workarounds from the old packaging logic, as we can now use NuGet extension points and avoid using a custom .nuspec. Commit migrated from dotnet/linker@010f98e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For dotnet/sdk#3125.
This most notably adds a net472 build of ILLink.Tasks, and modifies Sdk.props to import the correct build of the tasks, depending on the MSBuild runtime type. This makes it possible to use the linker tasks on desktop MSBuild once again. Regardless of the MSBuild runtime, illink.dll will run on .NET Core. We set 'rollForwardOnNoCandidateFx' to allow running on .NET Core 3 (even though illink.dl is built targeting netcoreapp2.0).
This change removes many workarounds from the old packaging logic, as we can now use NuGet extension points and avoid using a custom .nuspec.