Removing MSIL check for TorchSharp for now#6658
Merged
michaelgsharp merged 1 commit intodotnet:mainfrom May 5, 2023
Merged
Conversation
JakeRadMSFT
approved these changes
May 5, 2023
Member
|
It might be worth warning? I'm fine either way. |
Contributor
Author
|
@JakeRadMSFT we treat warnings as errors, so making this warn will still throw an error for us. The real way to do it would be to add a targets file in the nuget that somehow checks for something like this. That can come in later though as this is blocking some builds now. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6658 +/- ##
==========================================
+ Coverage 68.57% 68.58% +0.01%
==========================================
Files 1200 1200
Lines 250309 250326 +17
Branches 26095 26096 +1
==========================================
+ Hits 171647 171698 +51
+ Misses 71843 71814 -29
+ Partials 6819 6814 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the TorchSharp nuget is targetting x64 only while we are targeting AnyCPU. TorchSharp is targetting x64 because right now they only package the x64 binaries. We are targeting AnyCPU because in theory if someone compiled their own native code for non x64 and dropped it in it should still work.
Disabling the check for
MSB3270for now to resolve the issue. Will need to address this again when TorchSharp changes.