Add Span support in tokenizer's Model abstraction#7035
Merged
tarekgh merged 3 commits intodotnet:mainfrom Mar 1, 2024
Merged
Conversation
Member
Author
stephentoub
reviewed
Feb 28, 2024
stephentoub
reviewed
Feb 28, 2024
stephentoub
reviewed
Feb 28, 2024
stephentoub
reviewed
Feb 28, 2024
stephentoub
reviewed
Feb 28, 2024
stephentoub
reviewed
Feb 28, 2024
stephentoub
reviewed
Feb 28, 2024
stephentoub
reviewed
Feb 28, 2024
stephentoub
reviewed
Feb 28, 2024
stephentoub
reviewed
Feb 28, 2024
stephentoub
reviewed
Feb 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7035 +/- ##
==========================================
+ Coverage 68.79% 68.80% +0.01%
==========================================
Files 1254 1255 +1
Lines 250204 250248 +44
Branches 25529 25533 +4
==========================================
+ Hits 172127 172190 +63
+ Misses 71467 71449 -18
+ Partials 6610 6609 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is adding Span support to the Tokenizer's Model abstraction. This will help in performance and not restrict us in the future to use spans without to worry about more memory allocations.