Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependency versions and deprecates several test methods by adding [Obsolete] attributes and related warning suppressions. The key changes include:
- Marking diagnostic and test methods as obsolete to indicate deprecation.
- Adding SuppressMessage attributes with pending justifications in one test file.
- Updating a test to be skipped with an accompanying obsolete marker.
Reviewed Changes
Copilot reviewed 28 out of 38 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/Microsoft.ML.CodeAnalyzer.Tests/Helpers/CSharpCodeFixVerifier`2.cs | Added [Obsolete] attributes to the Diagnostic() overloads and applied warning suppression around an internal test class. |
| test/Microsoft.ML.CodeAnalyzer.Tests/Code/TypeParamNameTest.cs | Added an [Obsolete] attribute on the test method. |
| test/Microsoft.ML.CodeAnalyzer.Tests/Code/RelaxTestNamingTest.cs | Introduced multiple SuppressMessage attributes with "" justifications. |
| Others | Similar [Obsolete] attributes were added across various test files to mark methods for future deprecation. |
Files not reviewed (10)
- docs/samples/Microsoft.ML.GenAI.Samples/Microsoft.ML.GenAI.Samples.csproj: Language not supported
- docs/samples/Microsoft.ML.Samples/Microsoft.ML.Samples.csproj: Language not supported
- eng/Versions.props: Language not supported
- src/Microsoft.ML.AutoML.Interactive/Microsoft.ML.AutoML.Interactive.csproj: Language not supported
- src/Microsoft.ML.AutoML/Microsoft.ML.AutoML.csproj: Language not supported
- src/Microsoft.ML.GenAI.Core/Microsoft.ML.GenAI.Core.csproj: Language not supported
- src/Microsoft.ML.GenAI.Mistral/Microsoft.ML.GenAI.Mistral.csproj: Language not supported
- src/Microsoft.ML.GenAI.Phi/Microsoft.ML.GenAI.Phi.csproj: Language not supported
- test/Microsoft.ML.GenAI.Core.Tests/Microsoft.ML.GenAI.Core.Tests.csproj: Language not supported
- test/Microsoft.ML.GenAI.LLaMA.Tests/Microsoft.ML.GenAI.LLaMA.Tests.csproj: Language not supported
test/Microsoft.ML.CodeAnalyzer.Tests/Helpers/CSharpCodeFixVerifier`2.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.ML.CodeAnalyzer.Tests/Code/RelaxTestNamingTest.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.ML.CodeAnalyzer.Tests/Code/BestFriendOnPublicDeclarationTest.cs
Show resolved
Hide resolved
tools-local/Microsoft.ML.AutoML.SourceGenerator/EstimatorTypeGenerator.cs
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7457 +/- ##
=======================================
Coverage 68.99% 68.99%
=======================================
Files 1482 1482
Lines 273879 273880 +1
Branches 28254 28254
=======================================
+ Hits 188965 188967 +2
+ Misses 77531 77526 -5
- Partials 7383 7387 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Mac tests completing but then crashing at process exit:| |
|
Trying to update .NET runtime. If that doesn't help, we'll need to isolate the source of this error. Looks like it was present in @michaelgsharp's earlier work. |
eng/Versions.props
Outdated
| <MicrosoftCodeAnalysisCSharpVersion>4.13.0</MicrosoftCodeAnalysisCSharpVersion> | ||
| <MicrosoftDotNetInteractiveVersion>1.0.0-beta.25177.1</MicrosoftDotNetInteractiveVersion> | ||
| <MicrosoftMLOnnxRuntimeVersion>1.21.0</MicrosoftMLOnnxRuntimeVersion> | ||
| <MicrosoftMLOnnxRuntimeManagedVersion>1.21.2</MicrosoftMLOnnxRuntimeManagedVersion> |
There was a problem hiding this comment.
I don't see this property used anywhere.
| <MicrosoftMLOnnxRuntimeManagedVersion>1.21.2</MicrosoftMLOnnxRuntimeManagedVersion> |
|
Found a customer report of the same issue microsoft/onnxruntime#24579 |
|
Still broken with latest, will try to go back to older package. |
Update most dependency versions.