Skip to content

Comments

[vs17.6] Dont ngen taskhost Fixes our lack of optprof data (#8737)#8926

Merged
JanKrivanek merged 2 commits intodotnet:vs17.6from
JanKrivanek:vs17.6-optprof-patch
Jun 21, 2023
Merged

[vs17.6] Dont ngen taskhost Fixes our lack of optprof data (#8737)#8926
JanKrivanek merged 2 commits intodotnet:vs17.6from
JanKrivanek:vs17.6-optprof-patch

Conversation

@JanKrivanek
Copy link
Member

Context

OptProf failing on vs17.6 after recent changes

Fix

Cherrypicked #8737

@ghost
Copy link

ghost commented Jun 20, 2023

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this won't fix the builds by itself; we'll have to produce a build with disabled (or the old known-good) optprof data, spin up optprof collection, then rebuild with just a bumped version number.

Or we could just use the old known-good optprof data for 17.6.

@JanKrivanek JanKrivanek merged commit c70978d into dotnet:vs17.6 Jun 21, 2023
@JanKrivanek JanKrivanek deleted the vs17.6-optprof-patch branch June 21, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants