Do not consider DOTNET_ROOT when finding dotnet#69010
Merged
jaredpar merged 1 commit intodotnet:mainfrom Jul 17, 2023
Merged
Conversation
This changes our `dotnet` launch code to not consider `$DOTNET_ROOT` as that is a apphost specific variable. After discussion with the runtime team determined that only `$PATH` will be considered for finding `dotnet`. dotnet/runtime#88754
ghost
added
the
untriaged
Member
|
Reading the linked issue, I have no idea why not looking in DOTNET_ROOT is the right thing to do. If anything, I draw the opposite conclusion. Before we proceed with this, I think we need the guidance @richlander mentioned clearly documented. |
Member
Author
|
You can see there that |
333fred
approved these changes
Jul 13, 2023
| /// </summary> | ||
| /// <remarks> | ||
| /// See the following issue for rationale why only %PATH% is considered | ||
| /// https://github.com/dotnet/runtime/issues/88754 |
Member
There was a problem hiding this comment.
I'd honestly prefer the docs link here, that was far clearer than this thread 🙂
Member
Author
|
@dotnet/roslyn-compiler can i get one more review here, small change. |
jjonescz
approved these changes
Jul 17, 2023
This was referenced Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes our
dotnetlaunch code to not consider$DOTNET_ROOTas that is a apphost specific variable.After discussion with the runtime team determined that only
$PATHwill be considered for findingdotnet.dotnet/runtime#88754