Annotate remaining libraries for Nullable Reference Types

[stephentoub]

The following libraries in dotnet/runtime have not been annotated for Nullable Reference Types.

• Microsoft.Extensions.Hosting.Systemd
• System.CodeDom
• System.Diagnostics.EventLog
• System.Diagnostics.PerformanceCounter
• System.DirectoryServices.AccountManagement
• System.DirectoryServices.Protocols
• System.IO.Ports
• System.Management
• System.Runtime.Caching
• System.Speech

For each, we should either do so or decide we're never doing so.

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

---

The following libraries in dotnet/runtime have not been annotated for Nullable Reference Types.

• Microsoft.Extensions.Hosting.Systemd
• System.CodeDom
• System.Diagnostics.EventLog
• System.Diagnostics.PerformanceCounter
• System.DirectoryServices.AccountManagement
• System.DirectoryServices.Protocols
• System.IO.Ports
• System.Management
• System.Runtime.Caching
• System.Speech

For each, we should either do so or decide we're never doing so.

Author:	stephentoub
Assignees:	-
Labels:	area-Meta
Milestone:	Future

[maranmaran]

Are there any specific decisions so far about "never doing so" or listed libs are up for grabs and PR per lib?

[halgab]

I'm currently working on annotations for System.CodeDom. Should I send one big PR for the whole assembly or should I slice it in smaller parts?

[stephentoub]

Are there any specific decisions so far about "never doing so" or listed libs are up for grabs and PR per lib?

Nope

I'm currently working on annotations for System.CodeDom. Should I send one big PR for the whole assembly or should I slice it in smaller parts?

Either way is fine.

[drieseng]

System.Confguration is missing from the list above:

runtime/src/libraries/System.Configuration.ConfigurationManager/src/System.Configuration.ConfigurationManager.csproj

Lines 11 to 12 in c507305

	<!-- TODO https://github.com/dotnet/runtime/issues/90400: Annotate for nullable reference types -->
	<Nullable>disable</Nullable>