Simplify description of the SList data structure#100107
Closed
davidwrighton wants to merge 1 commit intodotnet:mainfrom
Closed
Simplify description of the SList data structure#100107davidwrighton wants to merge 1 commit intodotnet:mainfrom
davidwrighton wants to merge 1 commit intodotnet:mainfrom
Conversation
Member
davidwrighton
commented
Mar 21, 2024
davidwrighton
commented
- Remove the fields from the templated type, so the field offsets used within the type are always constant and defined by a non-templated structure (See usage of SListBase)
- Remove unused feature of SList, where the field present in the walkable structure can be configured to not be called m_Link
- Remove the fields from the templated type, so the field offsets used within the type are always constant and defined by a non-templated structure (See usage of SListBase) - Remove unused feature of SList, where the field present in the walkable structure can be configured to not be called m_Link
ghost
added
the
needs-area-label
davidwrighton
added a commit
to davidwrighton/runtime
that referenced
this pull request
Mar 21, 2024
- To start, I've added the contracts for iterating the thread list and gathering information about individual threads - Note that this algorithmic description is paired with a simplification of the SList data structure - See PR dotnet#100107
This was referenced Mar 22, 2024
davidwrighton
added a commit
that referenced
this pull request
Mar 23, 2024
…#99936) * Initial spec for the meaning and relationships between data contracts * Adjust to feedback * actually inclde the new spec in the new location * Merge in Jan's preamble * Add total type size to the layout info. * Add example algorithmic contracts - To start, I've added the contracts for iterating the thread list and gathering information about individual threads - Note that this algorithmic description is paired with a simplification of the SList data structure - See PR #100107 * Tweaks to some of the algorithms as suggested by Jan
am11
added
area-VM-coreclr
and removed
needs-area-label
Contributor
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
