Avoid LINQ expressions in getting GetService#100916
Merged
MichalStrehovsky merged 1 commit intodotnet:mainfrom Apr 11, 2024
Merged
Avoid LINQ expressions in getting GetService#100916MichalStrehovsky merged 1 commit intodotnet:mainfrom
GetService#100916MichalStrehovsky merged 1 commit intodotnet:mainfrom
Conversation
This makes ASP.NET 50 kB smaller with native AOT. We don't even need this `MethodInfo` but it's created in the static constructor along with other things that are needed so can't get rid of it. Could move it to a different type to get it fully out of the way. Note: this was previously grabbing `MethodInfo` of the lambda but that might have been unintentional.
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection |
stephentoub
approved these changes
Apr 11, 2024
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
This makes ASP.NET 50 kB smaller with native AOT. We don't even need this `MethodInfo` but it's created in the static constructor along with other things that are needed so can't get rid of it. Could move it to a different type to get it fully out of the way. Note: this was previously grabbing `MethodInfo` of the lambda but that might have been unintentional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes ASP.NET 50 kB smaller with native AOT.
We don't even need this
MethodInfobut it's created in the static constructor along with other things that are needed so can't get rid of it. Could move it to a different type to get it fully out of the way.Note: this was previously grabbing
MethodInfoof the lambda but that might have been unintentional.