Ensure Array.CreateInstance for reference types works#101048
Merged
MichalStrehovsky merged 1 commit intodotnet:mainfrom Apr 16, 2024
Merged
Ensure Array.CreateInstance for reference types works#101048MichalStrehovsky merged 1 commit intodotnet:mainfrom
MichalStrehovsky merged 1 commit intodotnet:mainfrom
Conversation
Follow up to dotnet#100626. The original fix only worked for unoptimized builds because the list of templates doesn't survive from scanning phase (when we do dataflow) to codegen phase (when we no longer do dataflow). The test that this was supposed to fix is still failing in dotnet#100331.
ghost
added
the
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
jkotas
approved these changes
Apr 15, 2024
lambdageek
added a commit
to lambdageek/runtime
that referenced
this pull request
Apr 19, 2024
Until we get dotnet#101048 from codeflow, work around dotnet#101205 by adding a trimmer root for JsonDerivedTypeAttribute[].
elinor-fung
pushed a commit
to elinor-fung/runtime
that referenced
this pull request
Apr 19, 2024
Until we get dotnet#101048 from codeflow, work around dotnet#101205 by adding a trimmer root for JsonDerivedTypeAttribute[].
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
Follow up to dotnet#100626. The original fix only worked for unoptimized builds because the list of templates doesn't survive from scanning phase (when we do dataflow) to codegen phase (when we no longer do dataflow). The test that this was supposed to fix is still failing in dotnet#100331.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #100626. The original fix only worked for unoptimized builds because the list of templates doesn't survive from scanning phase (when we do dataflow) to codegen phase (when we no longer do dataflow).
The test that this was supposed to fix is still failing in #100331.
Cc @dotnet/ilc-contrib