[cdac] Implement GetThreadStoreData in cDAC#102404
Merged
elinor-fung merged 4 commits intodotnet:mainfrom May 30, 2024
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @tommcdon |
elinor-fung
force-pushed
the
cdac-threadstore
branch
from
fe09ad6 to
890f9c6
Compare
elinor-fung
commented
May 20, 2024
|
|
||
| CDAC_TYPE_BEGIN(Thread) | ||
| CDAC_TYPE_INDETERMINATE(Thread) | ||
| CDAC_TYPE_FIELD(Thread, /*uint32*/, Id, cdac_offsets<Thread>::Id) |
Member
There was a problem hiding this comment.
I don't understand this comment type. Is that intentional going forward or a temporary mechanism?
Member
Author
There was a problem hiding this comment.
The type is optional as a mechanism for making the descriptor more compact. I left it off for these (and just put the comment), since I wasn't checking them.
lambdageek
approved these changes
May 28, 2024
Member
lambdageek
left a comment
lambdageek
left a comment
There was a problem hiding this comment.
lgtm, although I'm not a huge fan of the TryGet TryRegister pattern.
This was referenced May 30, 2024
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetThreadStoreDataandGetThreadCountsinThreadcontractISOSDacInterface::GetThreadStoreDatain cDACGetThreadDataif availableContributes to #99298
cc @lambdageek