Enable GeneratedRegex on partial properties#102977
Merged
stephentoub merged 4 commits intodotnet:mainfrom Jun 3, 2024
Merged
Conversation
|
Note regarding the |
RikkiGibson
approved these changes
Jun 3, 2024
danmoseley
approved these changes
Jun 3, 2024
campersau
reviewed
Jun 3, 2024
src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.Parser.cs
Show resolved
Hide resolved
src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.Parser.cs
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Jun 3, 2024
Member
eiriktsarpalis
left a comment
There was a problem hiding this comment.
Presumably this would require conceptual documentation updates?
Member
Author
Yes, we'll want to augment them to highlight the additional feature. |
This was referenced Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the attribute to apply to properties, and updates the source generator to support:
in addition to the already supported:
Closes #77797