ARM64-SVE: Saturating*ByActiveElementCount#102994
Merged
kunalspathak merged 4 commits intodotnet:mainfrom Jun 5, 2024
Merged
Conversation
|
Note regarding the |
ghost
added
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
Contributor
Author
|
Stress: Need to check if these are known issues. |
Contributor
Author
|
@dotnet/arm64-contrib @kunalspathak |
kunalspathak
reviewed
Jun 4, 2024
Contributor
kunalspathak
left a comment
kunalspathak
left a comment
There was a problem hiding this comment.
Looks good, except a question.
| } | ||
|
|
||
| // Switch instruction if arg1 is unsigned. | ||
| if (varTypeIsUnsigned(node->GetAuxiliaryType())) |
Contributor
There was a problem hiding this comment.
shouldn't this also use the unsigned variant of the instruction i.e. the first arg is Vector<ulong> and hence, the base type is ulong.
public static System.Numerics.Vector<ulong> SaturatingDecrementByActiveElementCount(System.Numerics.Vector<ulong> value, System.Numerics.Vector<ulong> from) { throw null; }
Contributor
Author
There was a problem hiding this comment.
Aux type is set as:
retNode->AsHWIntrinsic()->SetAuxiliaryJitType(op1BaseJitType);
So, for the example, GetAuxiliaryType() should be returning ulong
kunalspathak
approved these changes
Jun 4, 2024
Contributor
kunalspathak
left a comment
kunalspathak
left a comment
There was a problem hiding this comment.
LGTM. Can you fix the formatting errors too?
Contributor
Author
Done. |
Contributor
|
@a74nh - there is a merge conflict. |
This was referenced Jun 5, 2024
kunalspathak
reviewed
Jun 5, 2024
| acc += (mask[i] == 1) ? 1 : 0; | ||
| } | ||
| return acc; | ||
|
|
Contributor
There was a problem hiding this comment.
Missing } is causing build failure.
Contributor
|
/ba-g superpmi-replay failures are #102773 and machine agent issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.