Merged
Conversation
This reverts commit a2068b9.
lewing
requested review from
BrzVlad,
ilonatommy,
kotlarmilos and
maraf
as code owners
ghost
added
the
Member
|
I think the cause is probably the use of MUL_P_IMM in the new intrinsic. My guess is that (after optimization) the old non-intrinsic path would have used a shift in some cases, which is maybe slightly faster? It should be easy to fix, so I'll prep a PR for that. |
Open
3 tasks
kg
approved these changes
Jun 21, 2024
This was referenced Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #102670
I'm staging this because benchmarks show a regression in the NormalizeAscii benchmark, but I'm in no hurry to revert if we can think of a different resolution.