Add JsonMarshal.GetRawUtf8Value#104595
Merged
eiriktsarpalis merged 5 commits intodotnet:mainfrom Jul 10, 2024
Merged
Conversation
ghost
added
the
|
Note regarding the |
stephentoub
reviewed
Jul 9, 2024
src/libraries/System.Text.Json/src/System/Runtime/InteropServices/JsonMarshal.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Jul 9, 2024
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonElementParseTests.cs
Show resolved
Hide resolved
This was referenced Jul 9, 2024
Open
eiriktsarpalis
changed the title
JsonMarshal.TryGetRawValueJsonMarshal.GetRawUtf8Value
Member
Author
|
Updated to the approved API shape. |
This was referenced Jul 9, 2024
justindbaur
reviewed
Jul 9, 2024
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonElementParseTests.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 10, 2024
src/libraries/System.Text.Json/src/System/Runtime/InteropServices/JsonMarshal.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Jul 10, 2024
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
Other than the test naming comment, LGTM
This was referenced Jul 10, 2024
matouskozak
added a commit
to matouskozak/runtime
that referenced
this pull request
Jul 11, 2024
This reverts commit 635f9af.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #77666.
Pending API approval.cc @annelo-msft @KrzysztofCwalina