Delete FEATURE_READYTORUN_COMPILER ifdef#104727
Merged
MichalStrehovsky merged 2 commits intomainfrom Jul 12, 2024
Merged
Conversation
#103361 resurrected this long-deleted ifdef (crossgen1-specific code).
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Jul 11, 2024
Open
AndyAyersMS
approved these changes
Jul 11, 2024
Member
I think we could, yes, since we're mapping boxed value types to the internal box ref class. |
Member
Author
I've done that so that we don't need to synchronize this to the managed impl. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#103361 resurrected this long-deleted ifdef (it's crossgen1-specific define).
I actually wonder if we should roll back all changes to
getHeapClassSize- @EgorBo's #104411 doesn't fix getHeapClassSize to work with valuetypes and we don't have any failing tests, so maybe it doesn't need to handle valuetypes?