[browser][publish] Unicode in the path are parsed correctly in Windows for AOT/relink by emcc#105144
Merged
ilonatommy merged 6 commits intodotnet:mainfrom Jul 22, 2024
Merged
[browser][publish] Unicode in the path are parsed correctly in Windows for AOT/relink by emcc#105144ilonatommy merged 6 commits intodotnet:mainfrom
ilonatommy merged 6 commits intodotnet:mainfrom
Conversation
maraf
approved these changes
Jul 19, 2024
3 tasks
Member
Author
|
I merged to trigger closing and opening to see if it helps |
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83497. New emscripten had the required change.
The reason for blocking changed, if we shorten the path, e.g. by changing
s_unicodeChars = "\u9FC0\u8712\u679B\u906B\u486B\u7149" => "\u9FC0\u8712"and removingblz_aot_{config}_{GetRandomId()}from the project name (effectively, shortening the path to...compiled_methods.txt), the test passes. The remaining issue is problem with long paths on Windows.Now it fails with
which is #103625.