Add ZLib, Brotli compression options#105430
Merged
buyaa-n merged 11 commits intodotnet:mainfrom Jul 29, 2024
Merged
Conversation
|
Note regarding the |
|
Note regarding the |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-io-compression |
buyaa-n
commented
Jul 24, 2024
buyaa-n
commented
Jul 24, 2024
src/libraries/Common/tests/System/IO/Compression/CompressionStreamUnitTestBase.cs
Show resolved
Hide resolved
buyaa-n
commented
Jul 24, 2024
src/libraries/Common/tests/System/IO/Compression/CompressionStreamUnitTestBase.cs
Outdated
Show resolved
Hide resolved
e3ed2b6 to
f981aac
Compare
f981aac to
ecd4907
Compare
stephentoub
reviewed
Jul 25, 2024
...ibraries/System.IO.Compression.Brotli/src/System/IO/Compression/enc/BrotliStream.Compress.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 25, 2024
src/libraries/System.IO.Compression/src/System/IO/Compression/DeflateZLib/DeflateStream.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 25, 2024
src/libraries/System.IO.Compression.Brotli/tests/CompressionStreamUnitTests.Brotli.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jul 25, 2024
| { | ||
| Debug.Assert(windowBits >= minWindowBits && windowBits <= maxWindowBits); | ||
|
|
||
| int memLevel = options.CompressionLevel == 0 ? ZLibNative.Deflate_NoCompressionMemLevel : ZLibNative.Deflate_DefaultMemLevel; |
Member
There was a problem hiding this comment.
Has anyone requested being able to configure the memory level? I assume this is something we would consider adding as another property on the options in the future if it was needed?
Contributor
Author
There was a problem hiding this comment.
No real request, yes it can be added when needed
stephentoub
reviewed
Jul 25, 2024
src/libraries/System.IO.Compression/src/System/IO/Compression/DeflateZLib/Deflater.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jul 25, 2024
src/libraries/System.IO.Compression/tests/CompressionStreamUnitTests.Deflate.cs
Outdated
Show resolved
Hide resolved
f115adf to
e206031
Compare
…at failing in some CI legs
stephentoub
reviewed
Jul 26, 2024
src/libraries/Common/tests/System/IO/Compression/CompressionStreamUnitTestBase.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jul 26, 2024
...aries/System.IO.Compression.Brotli/src/System/IO/Compression/enc/BrotliCompressionOptions.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 26, 2024
src/libraries/System.IO.Compression/src/System/IO/Compression/ZLibCompressionOptions.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 26, 2024
src/libraries/System.IO.Compression/tests/CompressionStreamUnitTests.Deflate.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jul 26, 2024
src/libraries/System.IO.Compression/tests/CompressionStreamUnitTests.Gzip.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jul 26, 2024
src/libraries/System.IO.Compression/tests/CompressionStreamUnitTests.ZLib.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jul 26, 2024
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Contributor
carlossanlop
left a comment
There was a problem hiding this comment.
Thanks for working on this. I left a few comments for you to consider.
...aries/System.IO.Compression.Brotli/src/System/IO/Compression/enc/BrotliCompressionOptions.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.Compression/src/System/IO/Compression/ZLibCompressionOptions.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.Compression/src/System/IO/Compression/ZLibCompressionOptions.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.Compression/src/System/IO/Compression/ZLibCompressionOptions.cs
Outdated
Show resolved
Hide resolved
...aries/System.IO.Compression.Brotli/src/System/IO/Compression/enc/BrotliCompressionOptions.cs
Outdated
Show resolved
Hide resolved
...ibraries/System.IO.Compression.Brotli/src/System/IO/Compression/enc/BrotliStream.Compress.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.Compression/src/System/IO/Compression/DeflateZLib/DeflateStream.cs
Show resolved
Hide resolved
src/libraries/System.IO.Compression/tests/ZLibCompressionOptionsUnitTests.cs
Show resolved
Hide resolved
src/libraries/Common/tests/System/IO/Compression/CompressionStreamUnitTestBase.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/System/IO/Compression/CompressionStreamUnitTestBase.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
carlossanlop
approved these changes
Jul 26, 2024
d0335f8 to
35b3f9f
Compare
…ZLibCompressionOptions.cs Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
This was referenced Jul 29, 2024
buyaa-n
commented
Jul 29, 2024
src/libraries/System.IO.Compression/src/System/IO/Compression/ZLibCompressionOptions.cs
Outdated
Show resolved
Hide resolved
…ZLibCompressionOptions.cs
|
what about dictionary size |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approved API shape:
Fixes #42820