Export required symbols for FreeBSD ELFs#105587
Merged
jkotas merged 3 commits intodotnet:mainfrom Jul 28, 2024
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
am11
commented
Jul 27, 2024
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jul 27, 2024
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
Outdated
Show resolved
Hide resolved
…e.targets Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
reviewed
Jul 27, 2024
| <IlcArg Condition="'$(ExportsFile)' != ''" Include="--exportsfile:$(ExportsFile)" /> | ||
| <IlcArg Condition="'$(_targetOS)' == 'win' and '$(DebuggerSupport)' != 'false'" Include="--export-dynamic-symbol:DotNetRuntimeDebugHeader,DATA" /> | ||
| <IlcArg Condition="'$(_targetOS)' != 'win' and '$(DebuggerSupport)' != 'false'" Include="--export-dynamic-symbol:DotNetRuntimeDebugHeader" /> | ||
| <IlcArg Condition="'$(_targetOS)' == 'freebsd' and '$(DebuggerSupport)' != 'false'" Include="--export-dynamic-symbol:__progname;--export-dynamic-symbol:environ" /> |
Member
There was a problem hiding this comment.
For my education - where is the semicolon from this recognized as a separator? I do not think that the ILC command line parser treats semicolon as a separator.
Member
There was a problem hiding this comment.
MSBuild would consider this as a separator of the different items.
jkotas
reviewed
Jul 27, 2024
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
Outdated
Show resolved
Hide resolved
This was referenced Jul 28, 2024
Member
Author
|
root@cbsdnode:~/api1 # dotnet new webapiaot -n api1 && cd api1
root@cbsdnode:~/api1 # ~/.dotnet9/dotnet publish -p:PublishAot=true -p:StripSymbols=false -o dist --packages pkgs
root@cbsdnode:~/api1 # dist/api1 &
root@cbsdnode:~/api1 # info: Microsoft.Hosting.Lifetime[14]
Now listening on: http://localhost:5000
info: Microsoft.Hosting.Lifetime[0]
Application started. Press Ctrl+C to shut down.
info: Microsoft.Hosting.Lifetime[0]
Hosting environment: Production
info: Microsoft.Hosting.Lifetime[0]
Content root path: /root/api1
fetch -qo- http://localhost:5000/todos | jq
[
{
"id": 1,
"title": "Walk the dog",
"dueBy": null,
"isComplete": false
},
{
"id": 2,
"title": "Do the dishes",
"dueBy": "2024-07-27",
"isComplete": false
},
{
"id": 3,
"title": "Do the laundry",
"dueBy": "2024-07-28",
"isComplete": false
},
{
"id": 4,
"title": "Clean the bathroom",
"dueBy": null,
"isComplete": false
},
{
"id": 5,
"title": "Clean the car",
"dueBy": "2024-07-29",
"isComplete": false
}
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #105358