Initialize RuntimeEventSource as part of coreclr_initialize instead of only when running an app#105902
Merged
elinor-fung merged 2 commits intodotnet:mainfrom Aug 5, 2024
Merged
Conversation
Member
| should be updated too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83935
We were only initializing
RuntimeEventSourcebefore running an application. This meant that native hosting scenarios - COM, C++/CLI, custom - would never initialize it. As a result, diagnostic tracing tools - likedotnet-counters- did not work properly.This moves the call to
RuntimeEventSource.Initializeout ofStartupHookProvider.ManagedStartupand to be part ofcoreclr_initialize.Manually validated with dotnet-counters targeting native host and native client for C++/CLI or COM.
cc @dotnet/appmodel