Fix some NRT on StringCollection#106116
Conversation
|
Note regarding the |
1 similar comment
|
Note regarding the |
|
Tagging subscribers to this area: @dotnet/area-system-collections |
eiriktsarpalis
left a comment
There was a problem hiding this comment.
Looks reasonable based on the other APIs present in the collection. @stephentoub any objections?
stephentoub
left a comment
There was a problem hiding this comment.
This is correct and we should take it. Just note that it could introduce more warnings into a consumer.
|
How so? It's only input parameters and none of the changed methods are virtual. |
I was thinking this would warn: |
|
Thanks |
Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
StringCollectioncan containnullvalues. Fix annotations forAddRangeandCopyToto align with this.