[wasm] Enable the log profiler#107434
Merged
lewing merged 24 commits intodotnet:mainfrom Sep 12, 2024
Merged
Conversation
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
jeromelaban
force-pushed
the
dev/jela/log-profiler
branch
from
55c005e to
c10694a
Compare
26 tasks
jeromelaban
requested review from
BrzVlad,
lambdageek,
lewing,
marek-safar,
pavelsavara and
steveisok
as code owners
pavelsavara
added
arch-wasm
pavelsavara
reviewed
Sep 6, 2024
Member
pavelsavara
left a comment
pavelsavara
left a comment
There was a problem hiding this comment.
@jeromelaban what's the size of libmono-profiler-log.a ?
Contributor
Author
|
@pavelsavara interestingly, the dotnet.native.wasm seems to be smaller by 20 bytes with the log profiler included. |
pavelsavara
reviewed
Sep 6, 2024
pavelsavara
previously approved these changes
Sep 6, 2024
Member
|
adding |
This was referenced Sep 11, 2024
pavelsavara
reviewed
Sep 11, 2024
pavelsavara
approved these changes
Sep 11, 2024
ilonatommy
reviewed
Sep 11, 2024
Avoid "MSBUILD : error MSB1005: Specify a property and its value."
3 tasks
Member
|
From Jerome |
4 tasks
Member
|
There is about 1kb size growth in the range for the default build. But I can't tell if this is the .wasm file or DLLs. There are other changes in the diff.
@radekdoulik could you please advise ? |
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
* feat(wasm): Enable the log profiler * chore: Disable for wasi * chore: Add log profiler docs * chore: Adjust flush logs syntax * chore: Adjust defines, add conditionals, remove Module dependency * chore: Adjust buffer_unlock exclusion * chore: Adjust doc * chore: Add log profiler sample * chore: Add more sample logging * chore: Remove unused makefile target * chore: Remove icall, use jit interception to take heap sot * chore: Remove unused logs * chore: Remove unused dependency * Revert "chore: Remove unused dependency" This reverts commit 33221c4. * remove ENABLE_BROWSER_PROFILER from default build * Draft of WBT. * Miss-commit, there's no profiler.js in the sample. * Shift the responsibility of checking profile's size to the browser. * Test linking of all 3 types of loggers + running one of them. * link all 3 at the same time * fix [Fact] * Treat a list of loggers as one argument. Avoid "MSBUILD : error MSB1005: Specify a property and its value." * fix? --------- Co-authored-by: pavelsavara <pavel.savara@gmail.com> Co-authored-by: Ilona Tomkowicz <itomkowicz@microsoft.com> Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com> Co-authored-by: Pavel Savara <pavelsavara@microsoft.com>
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
* feat(wasm): Enable the log profiler * chore: Disable for wasi * chore: Add log profiler docs * chore: Adjust flush logs syntax * chore: Adjust defines, add conditionals, remove Module dependency * chore: Adjust buffer_unlock exclusion * chore: Adjust doc * chore: Add log profiler sample * chore: Add more sample logging * chore: Remove unused makefile target * chore: Remove icall, use jit interception to take heap sot * chore: Remove unused logs * chore: Remove unused dependency * Revert "chore: Remove unused dependency" This reverts commit 33221c4. * remove ENABLE_BROWSER_PROFILER from default build * Draft of WBT. * Miss-commit, there's no profiler.js in the sample. * Shift the responsibility of checking profile's size to the browser. * Test linking of all 3 types of loggers + running one of them. * link all 3 at the same time * fix [Fact] * Treat a list of loggers as one argument. Avoid "MSBUILD : error MSB1005: Specify a property and its value." * fix? --------- Co-authored-by: pavelsavara <pavel.savara@gmail.com> Co-authored-by: Ilona Tomkowicz <itomkowicz@microsoft.com> Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com> Co-authored-by: Pavel Savara <pavelsavara@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the support for the log profiler discussed in #107312 for webassembly.
The inclusion follows the support for the browser and aot profilers.
Closes #107312