JIT: Remove fallthrough checks in Compiler::TryLowerSwitchToBitTest#108106
Merged
amanasifkhalid merged 3 commits intodotnet:mainfrom Oct 16, 2024
Merged
JIT: Remove fallthrough checks in Compiler::TryLowerSwitchToBitTest#108106amanasifkhalid merged 3 commits intodotnet:mainfrom
amanasifkhalid merged 3 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
3 tasks
Contributor
Author
|
cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Modest diffs -- this change is creating instances where the |
Contributor
Author
|
ping @AndyAyersMS |
AndyAyersMS
approved these changes
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #107749, and prerequisite to #107634. If we intend to run block layout after lowering, then we shouldn't bother checking for fallthrough during switch lowering -- instead, rely on block layout to create fallthrough from the bit test if it is beneficial.