Assign VN for COMMA in gtWrapWithSideEffects#108955
Merged
EgorBo merged 10 commits intodotnet:mainfrom Oct 17, 2024
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Merged
This was referenced Oct 17, 2024
Member
Author
|
@MihuBot -dependsOn 108838 |
Member
Author
|
PTAL @AndyAyersMS @dotnet/jit-contrib using System;
using System.Runtime.CompilerServices;
class Program
{
static void Main()
{
for (int i=0; i<200; i++) {
Test();
Thread.Sleep(16);
}
}
[MethodImpl(MethodImplOptions.NoInlining)]
static int Test() => MyArray.arr[2]; // should drop bound checks, array length is known
}
class MyArray {
public static readonly int[] arr = new int[10];
}at least, it's a clean up.. |
src/coreclr/jit/gentree.cpp
Outdated
Comment on lines
17226
to
17228
| GenTree* comma = gtNewOperNode(GT_COMMA, tree->TypeGet(), sideEffects, tree); | ||
| comma->gtVNPair = tree->gtVNPair; | ||
| return comma; |
Contributor
There was a problem hiding this comment.
This needs to attach the exception set from sideEffects.
AndyAyersMS
approved these changes
Oct 17, 2024
Contributor
|
@MihuBot -dependsOn 108838,108606 |
Contributor
Member
Author
|
SPMI failures are due to JIT-EE bump in a PR merged recently |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's see if this works out on CI..