[Release/8.0] Fix FP state restore on macOS exception forwarding#109579
Merged
janvorli merged 1 commit intodotnet:release/8.0-stagingfrom Dec 3, 2024
Merged
Conversation
Backport of dotnet#105003, dotnet#109458 and part of dotnet#99255
jeffschwMSFT
approved these changes
Nov 6, 2024
Member
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. we will take for consideration in 8.0.x
VSadov
approved these changes
Nov 7, 2024
Contributor
|
It looks like this fix is also needed on .NET 9 + Intel + macOS. From (build log): Note the |
Member
Author
Right, I've created a backporting PR to 9 for that today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #105003, #109458 and part of #99255
Customer Impact
[x] Customer reported
[ ] Found internally
Original issue: #109423
Attempt to load Java VM into .NET process on macOS x64 always crashes due to a problem in hardware exception forwarding from coreclr's exception handling port to Java's exception handling port (or any other registered one).
Regression
[x] Yes
[ ] No
Regression in .NET 8.0.8 due to a change to fix AVX512 support on macOS for debugging.
Testing
Testing using a repro provided by the customer and coreclr tests
Risk
Low, fixes a buffer overflow, a stack overflow and obviously incorrect floating point context restoration in case of hardware exception in external non-.NET code.