Allow nibblemap deletes to be no-op#109976
Merged
max-charlamb merged 2 commits intodotnet:mainfrom Nov 20, 2024
Merged
Conversation
ghost
added
the
steveisok
approved these changes
Nov 19, 2024
davmason
approved these changes
Nov 19, 2024
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
* allow no-op deletes * improve comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #109970
#108939 changed nibblemap delete function to assert that the delete operation occurred on a valid nibble. Testing with the AltJit triggered the revert path (
BackoutJitData) which attempts to delete the nibblemap entry which is never set.In other paths the nibblemap entry has already been set, therefore I am modifying the assert to allow no-op deletes. This should be the same behavior as before #108939.