Merged
Conversation
Member
Author
|
/cc @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (4)
- src/coreclr/inc/jithelpers.h: Language not supported
- src/coreclr/vm/corelib.h: Language not supported
- src/coreclr/vm/jithelpers.cpp: Language not supported
- src/coreclr/vm/metasig.h: Language not supported
Contributor
|
Tagging subscribers to this area: @mangod9 |
25 tasks
jkoritzinsky
reviewed
Jan 6, 2025
Member
|
@EgorBot -windows_intel using System;
using System.Runtime.CompilerServices;
using BenchmarkDotNet.Attributes;
public class Bench
{
[MethodImpl(MethodImplOptions.NoInlining)]
internal Type M<T>() => typeof(T);
[Benchmark]
public Type GenericTypeOf() => M<string>();
} |
jkotas
reviewed
Jan 6, 2025
jkotas
reviewed
Jan 8, 2025
...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jan 8, 2025
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 16 changed files in this pull request and generated no comments.
Files not reviewed (13)
- src/coreclr/debug/ee/frameinfo.h: Language not supported
- src/coreclr/inc/jithelpers.h: Language not supported
- src/coreclr/inc/vptr_list.h: Language not supported
- src/coreclr/vm/corelib.h: Language not supported
- src/coreclr/vm/ecalllist.h: Language not supported
- src/coreclr/vm/frames.cpp: Language not supported
- src/coreclr/vm/frames.h: Language not supported
- src/coreclr/vm/jithelpers.cpp: Language not supported
- src/coreclr/vm/metasig.h: Language not supported
- src/coreclr/vm/runtimehandles.cpp: Language not supported
- src/coreclr/vm/runtimehandles.h: Language not supported
- src/coreclr/vm/typedesc.cpp: Language not supported
- src/coreclr/vm/typedesc.h: Language not supported
Comments suppressed due to low confidence (1)
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs:54
- Ensure that
AuxiliaryDatais defined and used correctly in the context ofGetRuntimeTypeFromHandle.
return (h.IsTypeDesc ? h.AsTypeDesc()->ExposedClassObject : h.AsMethodTable()->AuxiliaryData->ExposedClassObject) ?? GetRuntimeTypeFromHandleSlow(handle);
Member
Author
|
@jkotas Got it back to parity - EgorBot/runtime-utils#225 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert
JIT_UserBreakpointto C#.Convert
JIT_GetRuntimeTypeandJIT_GetRuntimeType_MaybeNullto C#.Contributes to #95695